Add default values and fix empty descriptions renderings #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actual value might be `null`, which doesn't loko very nice in the docs, replaced with an empty string.
Arguments and input values might have a default value, which should be reflected in the docs. This commit will show it like `limit: Int = 10`. Related: 2fd#53
treble-snake
force-pushed
the
add-default-values
branch
from
921859c to
dc90af0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 changes:
First, if an item or a node doesn't have a description, the actual value in the AST might be
null.There was a small bug about not casting the value to an empty string, so
nullwould be rendered on the web page.Second, arguments and input values might have a default value, which I believe should be reflected in the docs.
I added a simple piece of code rendering that like
limit: Int = 10.Cheers!
Related issues: #53