Unused variant config

Author: kornelski

rmp-serde/src/config.rs

@@ -83,19 +83,6 @@ impl sealed::SerializerConfig for DefaultConfig {
         value.serialize(ser)
     }
 
-    #[inline]
-    fn write_variant_ident<S>(
-        ser: &mut S,
-        _variant_index: u32,
-        variant: &'static str,
-    ) -> Result<(), Error>
-    where
-        S: UnderlyingWrite,
-        for<'a> &'a mut S: Serializer<Ok = (), Error = Error>,
-    {
-        ser.serialize_str(variant)
-    }
-
     #[inline(always)]
     fn is_human_readable() -> bool {
         false
@@ -144,19 +131,6 @@ where
         value.serialize(ser)
     }
 
-    #[inline]
-    fn write_variant_ident<S>(
-        ser: &mut S,
-        variant_index: u32,
-        variant: &'static str,
-    ) -> Result<(), Error>
-    where
-        S: UnderlyingWrite,
-        for<'a> &'a mut S: Serializer<Ok = (), Error = Error>,
-    {
-        C::write_variant_ident(ser, variant_index, variant)
-    }
-
     #[inline(always)]
     fn is_human_readable() -> bool {
         C::is_human_readable()
@@ -200,19 +174,6 @@ where
         value.serialize(ser)
     }
 
-    #[inline]
-    fn write_variant_ident<S>(
-        ser: &mut S,
-        variant_index: u32,
-        variant: &'static str,
-    ) -> Result<(), Error>
-    where
-        S: UnderlyingWrite,
-        for<'a> &'a mut S: Serializer<Ok = (), Error = Error>,
-    {
-        C::write_variant_ident(ser, variant_index, variant)
-    }
-
     #[inline(always)]
     fn is_human_readable() -> bool {
         C::is_human_readable()
@@ -255,19 +216,6 @@ where
         C::write_struct_field(ser, key, value)
     }
 
-    #[inline]
-    fn write_variant_ident<S>(
-        ser: &mut S,
-        variant_index: u32,
-        variant: &'static str,
-    ) -> Result<(), Error>
-    where
-        S: UnderlyingWrite,
-        for<'a> &'a mut S: Serializer<Ok = (), Error = Error>,
-    {
-        C::write_variant_ident(ser, variant_index, variant)
-    }
-
     #[inline(always)]
     fn is_human_readable() -> bool {
         true
@@ -310,19 +258,6 @@ where
         C::write_struct_field(ser, key, value)
     }
 
-    #[inline]
-    fn write_variant_ident<S>(
-        ser: &mut S,
-        variant_index: u32,
-        variant: &'static str,
-    ) -> Result<(), Error>
-    where
-        S: UnderlyingWrite,
-        for<'a> &'a mut S: Serializer<Ok = (), Error = Error>,
-    {
-        C::write_variant_ident(ser, variant_index, variant)
-    }
-
     #[inline(always)]
     fn is_human_readable() -> bool {
         false

rmp-serde/src/encode.rs

@@ -591,7 +591,7 @@ where
     fn serialize_unit_variant(self, _name: &str, idx: u32, variant: &'static str) ->
         Result<Self::Ok, Self::Error>
     {
-        C::write_variant_ident(self, idx, variant)
+        self.serialize_str(variant)
     }
 
     fn serialize_newtype_struct<T: ?Sized + serde::Serialize>(self, name: &'static str, value: &T) -> Result<(), Self::Error> {
@@ -609,7 +609,7 @@ where
     fn serialize_newtype_variant<T: ?Sized + serde::Serialize>(self, _name: &'static str, idx: u32, variant: &'static str, value: &T) -> Result<Self::Ok, Self::Error> {
         // encode as a map from variant idx to its attributed data, like: {idx => value}
         encode::write_map_len(&mut self.wr, 1)?;
-        C::write_variant_ident(self, idx, variant)?;
+        self.serialize_str(variant)?;
         value.serialize(self)
     }
 
@@ -637,7 +637,7 @@ where
     {
         // encode as a map from variant idx to a sequence of its attributed data, like: {idx => [v1,...,vN]}
         encode::write_map_len(&mut self.wr, 1)?;
-        C::write_variant_ident(self, idx, variant)?;
+        self.serialize_str(variant)?;
         self.serialize_tuple(len)
     }
 
@@ -652,12 +652,12 @@ where
         self.compound()
     }
 
-    fn serialize_struct_variant(self, name: &'static str, id: u32, variant: &'static str, len: usize) ->
+    fn serialize_struct_variant(self, name: &'static str, _: u32, variant: &'static str, len: usize) ->
         Result<Self::SerializeStructVariant, Error>
     {
         // encode as a map from variant idx to a sequence of its attributed data, like: {idx => [v1,...,vN]}
         encode::write_map_len(&mut self.wr, 1)?;
-        C::write_variant_ident(self, id, variant)?;
+        self.serialize_str(variant)?;
         self.serialize_struct(name, len)
     }
 }