Unified catalog interface for segment (milvus-io#18289) (milvus-io#18290)

Signed-off-by: kejiang <[email protected]>

Signed-off-by: kejiang <[email protected]>
Co-authored-by: kejiang <[email protected]>

Author: jiangke-sr

internal/datacoord/compaction_test.go

@@ -22,6 +22,7 @@ import (
 	"time"
 
 	memkv "github.com/milvus-io/milvus/internal/kv/mem"
+	"github.com/milvus-io/milvus/internal/metastore/kv/datacoord"
 	"github.com/milvus-io/milvus/internal/proto/datapb"
 	"github.com/milvus-io/milvus/internal/util/tsoutil"
 	"github.com/stretchr/testify/assert"
@@ -153,7 +154,7 @@ func Test_compactionPlanHandler_completeCompaction(t *testing.T) {
 				},
 				nil,
 				&meta{
-					client: memkv.NewMemoryKV(),
+					catalog: &datacoord.Catalog{Txn: memkv.NewMemoryKV()},
 					segments: &SegmentsInfo{
 						map[int64]*SegmentInfo{
 							1: {SegmentInfo: &datapb.SegmentInfo{ID: 1, Binlogs: []*datapb.FieldBinlog{getFieldBinlogPaths(1, "log1")}}},
@@ -202,7 +203,7 @@ func Test_compactionPlanHandler_completeCompaction(t *testing.T) {
 				},
 				nil,
 				&meta{
-					client: memkv.NewMemoryKV(),
+					catalog: &datacoord.Catalog{Txn: memkv.NewMemoryKV()},
 					segments: &SegmentsInfo{
 						map[int64]*SegmentInfo{
 
@@ -289,7 +290,7 @@ func Test_compactionPlanHandler_segment_is_referenced(t *testing.T) {
 				},
 				nil,
 				&meta{
-					client: memkv.NewMemoryKV(),
+					catalog: &datacoord.Catalog{Txn: memkv.NewMemoryKV()},
 					segments: &SegmentsInfo{
 						map[int64]*SegmentInfo{
 

internal/datacoord/handler.go

@@ -166,11 +166,11 @@ func (h *ServerHandler) CheckShouldDropChannel(channel string) bool {
 			}
 		}
 		return false*/
-	return h.s.meta.ChannelHasRemoveFlag(channel)
+	return h.s.meta.catalog.IsChannelDropped(h.s.ctx, channel)
 }
 
 // FinishDropChannel cleans up the remove flag for channels
 // this function is a wrapper of server.meta.FinishDropChannel
 func (h *ServerHandler) FinishDropChannel(channel string) {
-	h.s.meta.FinishRemoveChannel(channel)
+	h.s.meta.catalog.DropChannel(h.s.ctx, channel)
 }