Bug#33069747 ASSERTION `M_COUNT >= M_FRAME_NULL_COUNT && M_FRAME_NULL_COUNT > 0' FAILED

Missing call to split_sum func caused error when accessing rows from a
window frame of a window function call only present in the ORDER BY
list. This means that the argument of the window function was never
put in the select list nor never replaced with an Item_aggregate_ref
to it (in base_ref_items), cf. what happens if the window function is
part of an expression in the select list.

Change-Id: I287b701c48d0f96e57acba93b98f0312394a53c3

Author: Dag Wanvik

mysql-test/r/window_functions_bugs.result

@@ -1664,3 +1664,32 @@ a	PERCENT_RANK() OVER (ORDER BY a)
 NULL	0
 02:00:00	1
 DROP TABLE t1;
+#
+# Bug#33069747 ASSERTION `M_COUNT >= M_FRAME_NULL_COUNT && M_FRAME_NULL_COUNT > 0' FAILED
+#
+CREATE TABLE t1 ( a INTEGER, b INTEGER );
+INSERT INTO t1 VALUES (0,NULL);
+INSERT INTO t1 VALUES (NULL,1);
+ANALYZE TABLE t1;
+Table	Op	Msg_type	Msg_text
+test.t1	analyze	status	OK
+SELECT 1 FROM t1
+ORDER BY BIT_OR(a) OVER (ORDER BY b ROWS CURRENT ROW);
+1
+1
+1
+SELECT SUM(a) OVER w
+FROM t1
+WINDOW w AS (ORDER BY b ROWS CURRENT ROW)
+ORDER BY SUM(b) OVER w;
+SUM(a) OVER w
+0
+NULL
+SELECT a, b, SUM(a) OVER w, SUM(b) OVER w
+FROM t1
+WINDOW w AS (ORDER BY b ROWS CURRENT ROW)
+ORDER BY SUM(b) OVER w;
+a	b	SUM(a) OVER w	SUM(b) OVER w
+0	NULL	0	NULL
+NULL	1	NULL	1
+DROP TABLE t1;

mysql-test/t/window_functions_bugs.test

@@ -1127,3 +1127,28 @@ INSERT INTO t1 VALUES (NULL);
 SELECT a, PERCENT_RANK() OVER (ORDER BY a) FROM t1;
 
 DROP TABLE t1;
+
+--echo #
+--echo # Bug#33069747 ASSERTION `M_COUNT >= M_FRAME_NULL_COUNT && M_FRAME_NULL_COUNT > 0' FAILED
+--echo #
+
+CREATE TABLE t1 ( a INTEGER, b INTEGER );
+
+INSERT INTO t1 VALUES (0,NULL);
+INSERT INTO t1 VALUES (NULL,1);
+ANALYZE TABLE t1;
+
+SELECT 1 FROM t1
+ORDER BY BIT_OR(a) OVER (ORDER BY b ROWS CURRENT ROW);
+
+SELECT SUM(a) OVER w
+FROM t1
+WINDOW w AS (ORDER BY b ROWS CURRENT ROW)
+ORDER BY SUM(b) OVER w;
+
+SELECT a, b, SUM(a) OVER w, SUM(b) OVER w
+FROM t1
+WINDOW w AS (ORDER BY b ROWS CURRENT ROW)
+ORDER BY SUM(b) OVER w;
+
+DROP TABLE t1;

sql/sql_resolver.cc

@@ -4624,8 +4624,7 @@ bool Query_block::setup_order_final(THD *thd) {
         (item->type() == Item::SUM_FUNC_ITEM && !item->m_is_window_function);
     if (is_grouped_aggregate) continue;
 
-    if (item->has_aggregation() ||
-        (!item->m_is_window_function && item->has_wf())) {
+    if (item->has_aggregation() || item->has_wf()) {
       item->split_sum_func(thd, base_ref_items, &fields);
       if (thd->is_error()) return true; /* purecov: inspected */
     }