Cannot create ADF trigger annotations using Python SDK

[VKovalchuk-danone]

• Package Name: azure-mgmt-datafactory
• Package Version: 3.1.0
• Operating System: Linux, Windows
• Python Version: 3.10

Describe the bug
ADF triggers may have "annotations" but wrong type in Azure Python SDK doesn't allow creating them with Python code. (Most possibly this bug is present for other ADF resources, too.)

To Reproduce
Steps to reproduce the behavior:

1. Adapt and run the code:

from azure.mgmt.datafactory.models import ScheduleTrigger, ...

trigger_resource = TriggerResource(
            properties=ScheduleTrigger(
                recurrence=ScheduleTriggerRecurrence( ...some params, not important ),
                description=some_description,
                annotations=["test"],
                pipelines=[TriggerPipelineReference(pipeline_reference=..., parameters=...)],
            )
        )
adf_client = DataFactoryManagementClient(credential, some_subscription_id)
adf_client.triggers.create_or_update(some_resource_group_name, some_factory_name, trigger_name, trigger_resource)

2. It creates a trigger that does not have any annotation;
3. Check types using mypy, it says annotation must be List[JSON] which is alias for MutableMapping[str, Any] but annotations must be List[str] type.

Expected behavior
Trigger annotation are expected to be created.

Screenshots

Additional context
We are going to use annotations for further filtering so it would be important.
Also note we are creating triggers using Python SDK, Management API and not using ARM templates (which obviously work).
Usage of Python is mandatory, we can't use other SDKs.

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @hvermis.

[msyyc]

@ChenxiJiang333 please help take a look on this issue.

[ChenxiJiang333]

got it

[ChenxiJiang333]

Hi @VKovalchuk-danone, I have tried your code and it successfully created the annotations, could you try whether azure-mgmt-datafactory==9.2.0 works as expected? You may also need to refresh the page once you make any change by sdk.

[github-actions]

Hi @VKovalchuk-danone. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.

[github-actions]

Hi @VKovalchuk-danone, since you haven’t asked that we /unresolve the issue, we’ll close this out. If you believe further discussion is needed, please add a comment /unresolve to reopen the issue.