Bug#32673736 - AUTOTEST: TESTINDEX -N DEFERREDERROR FAILS WITH ARBITRATION ERROR

Lost arbitration ticket problem: The previous test 'testNodeRestart -n
Bug18612SR T1' leaves the cluster in a partitioned state with each
partition having node-1 as arbitrator, but separately, with different
tickets, say node-2 having ticket t1 and node-3 - t2, where t1
committed last, thus t2 is forgotten by the arbitrator.

This causes the following 'TESTINDEX -N DEFERREDERROR' execution to
fail when it takes node-2 down, due to the new arbitration fails with
'invalid arbitration ticket' error.

Fix: Introduce a clean up at the end for the previous test.

Reviewed by: Frazer Clement <[email protected]>

Author: Maitrayi Sabaratnam

storage/ndb/test/ndbapi/testNodeRestart.cpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2019, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2003, 2021, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -6856,6 +6856,15 @@ runBug18044717(NDBT_Context* ctx, NDBT_Step* step)
   return result;
 }
 
+int runRestartAllNodes(NDBT_Context* ctx, NDBT_Step* step)
+{
+  NdbRestarter restarter;
+  CHECK(restarter.restartAll() == 0, "-");
+  CHECK(restarter.waitClusterNoStart() == 0, "-");
+  CHECK(restarter.startAll() == 0, "-");
+  CHECK(restarter.waitClusterStarted() == 0, "-");
+  CHK_NDB_READY(GETNDB(step));
+}
 
 
 static int createEvent(Ndb *pNdb,
@@ -8312,6 +8321,7 @@ TESTCASE("Bug18612SR",
 	 "Test bug with partitioned clusters"){
   INITIALIZER(runLoadTable);
   STEP(runBug18612SR);
+  FINALIZER(runRestartAllNodes);
   FINALIZER(runClearTable);
 }
 TESTCASE("Bug20185",