handle 0 results from getHistory without error-ing

jlindberg-oss · web-flow · commit ac4b5d9199e1 · 2018-04-07T23:44:59.000-04:00
Similar to getLogs, getHistory seems to return `result.status == 0` when there are no results found.
diff --git a/providers/etherscan-provider.js b/providers/etherscan-provider.js
@@ -59,8 +59,8 @@ utils.defineProperty(EtherscanProvider.prototype, '_callProxy', function() {
 });
 
 function getResult(result) {
-    // getLogs has weird success responses
-    if (result.status == 0 && result.message === 'No records found') {
+    // getLogs, getHistory have weird success responses
+    if (result.status == 0 && (result.message === 'No records found' || result.message === 'No transactions found')) {
         return result.result;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ utils.defineProperty(EtherscanProvider.prototype, '_callProxy', function() {`
`59`	`59`	`});`
`60`	`60`
`61`	`61`	`function getResult(result) {`
`62`		`- // getLogs has weird success responses`
`63`		`- if (result.status == 0 && result.message === 'No records found') {`
	`62`	`+ // getLogs, getHistory have weird success responses`
	`63`	`+ if (result.status == 0 && (result.message === 'No records found' \|\| result.message === 'No transactions found')) {`
`64`	`64`	`return result.result;`
`65`	`65`	`}`
`66`	`66`