Detect artifact corruption #637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
- Coverage 88.92% 88.91% -0.01%
==========================================
Files 50 50
Lines 15967 15974 +7
==========================================
+ Hits 14198 14204 +6
- Misses 1769 1770 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When the workspace is emptied, the audit trail gets obsolete. Even more importantly, we do not want to accidentally reuse the old audit trail if the new artifact did not have one.
We do not upload artifacts that miss an audit trail. On the other hand, we should reject downloaded artifacts that have no audit trail. Otherwise, downstream artifacts will have their audit trail corrupted.
The audit trail names the expected hash of the content. Assert that the hash sum matches after the artifact has been extracted. This should detect any accidental corruptions of the archive. Note that this will not help against malicious modifications. To detect such tampering, some kind of cryptographically strong signature check needs to be implemented. Fixes BobBuildTool#636.
jkloetzke
force-pushed
the
detect-artifact-corruption
branch
from
5e44869 to
e01ffe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.