fix(ibm): actually fix attaching of floating ips

A boolean was being checked against None incorrectly
so the falsey value was not respected. This fixes that.

Author: a-dubs

VERSION

@@ -1 +1 @@
-1!9.3.0
+1!9.3.1

pycloudlib/ibm/instance.py

@@ -652,15 +652,15 @@ def _attach_floating_ip_until_success(
         Raises:
             IBMException: If failed to attach floating IP after 10 tries
         """
-        attached_floating_ip = None
+        floating_ip_is_attached = None
         self._log.info(
             "Will attempt to attach floating ip with name containing: %s"
             "until successful or all floating ips are in use.",
             floating_ip_substring,
         )
 
         tries = 0
-        while attached_floating_ip is None:
+        while not floating_ip_is_attached:
             tries += 1
             target_floating_ip = self._choose_from_existing_floating_ips(
                 name_includes=floating_ip_substring,
@@ -669,8 +669,10 @@ def _attach_floating_ip_until_success(
                 "Attempting to attach floating ip: %s",
                 target_floating_ip["name"],
             )
-            attached_floating_ip = self._attach_floating_ip(target_floating_ip)
-            if not attached_floating_ip:
+            floating_ip_is_attached = self._attach_floating_ip(
+                floating_ip=target_floating_ip
+            )
+            if not floating_ip_is_attached:
                 self._log.info(
                     "Failed to attach floating ip: %s. Will try again.",
                     target_floating_ip["name"],