Skip to content

Commit 3c1bad2

Browse files
committed
Fix stray promises when a node returns invalid results (ethers-io#4118).
1 parent f37a52d commit 3c1bad2

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src.ts/providers/provider-jsonrpc.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,12 @@ export abstract class JsonRpcApiProvider extends AbstractProvider {
505505

506506
// No result; the node failed us in unexpected ways
507507
if (resp == null) {
508-
return reject(makeError("no response from server", "BAD_DATA", { value: result, info: { payload } }));
508+
const error = makeError("missing response for request", "BAD_DATA", {
509+
value: result, info: { payload }
510+
});
511+
this.emit("error", error);
512+
reject(error);
513+
continue;
509514
}
510515

511516
// The response is an error

0 commit comments

Comments
 (0)