Fix lost promise fulfillment when a batch has an error response (ethers-io#4126).

ricmoo · ricmoo · commit 8dd21f03334f · 2023-06-07T20:09:29.000-04:00
diff --git a/src.ts/providers/provider-jsonrpc.ts b/src.ts/providers/provider-jsonrpc.ts
@@ -515,7 +515,8 @@ export abstract class JsonRpcApiProvider extends AbstractProvider {
 
                             // The response is an error
                             if ("error" in resp) {
-                                return reject(this.getRpcError(payload, resp));
+                                reject(this.getRpcError(payload, resp));
+                                continue;
                             }
 
                             // All good; send the result

Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,8 @@ export abstract class JsonRpcApiProvider extends AbstractProvider {`
`515`	`515`
`516`	`516`	`// The response is an error`
`517`	`517`	`if ("error" in resp) {`
`518`		`- return reject(this.getRpcError(payload, resp));`
	`518`	`+ reject(this.getRpcError(payload, resp));`
	`519`	`+ continue;`
`519`	`520`	`}`
`520`	`521`
`521`	`522`	`// All good; send the result`