Skip to content

Commit 1cc8069

Browse files
committed
Update RSSManager.java
Fixed XML External Entity (XXE) Processing. Check https://www.owasp.org/index.php/XML_External_Entity_%28XXE%29_Processing for more details on this
1 parent cc2c6da commit 1cc8069

File tree

1 file changed

+3
-1
lines changed
  • rss-middletier/src/main/java/com/netflix/recipes/rss/manager

1 file changed

+3
-1
lines changed

rss-middletier/src/main/java/com/netflix/recipes/rss/manager/RSSManager.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,8 @@ private RSS parseRSS(String url, String rss) {
147147

148148
RSS rssItems = null;
149149
DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
150+
String FEATURE = "http://apache.org/xml/features/disallow-doctype-decl";
151+
dbf.setFeature(FEATURE, true);
150152
try {
151153
DocumentBuilder db = dbf.newDocumentBuilder();
152154
try {
@@ -183,4 +185,4 @@ private RSS parseRSS(String url, String rss) {
183185
public int getStatus() {
184186
return store == null ? 500 : 200;
185187
}
186-
}
188+
}

0 commit comments

Comments
 (0)