fix(callbacks): Bind public instance to callbacks - fixes BrowserSync#674

Author: Shane Osbourne

lib/browser-sync.js

@@ -59,7 +59,7 @@ BrowserSync.prototype.callback = function (name) {
     var cb  = bs.options.getIn(["callbacks", name]);
 
     if (_.isFunction(cb)) {
-        cb.apply(bs, _.toArray(arguments).slice(1));
+        cb.apply(bs.publicInstance, _.toArray(arguments).slice(1));
     }
 };
 

test/specs/e2e/e2e.options.callbacks.js

@@ -1,10 +1,11 @@
 "use strict";
 
 var browserSync = require("../../../");
+var assert      = require("chai").assert;
 
 describe("E2E options test - ready callback as option", function () {
 
-    it("Sets the available port", function (done) {
+    it("Calls the ready callback when read", function (done) {
         browserSync.reset();
         browserSync({
             server:   {
@@ -20,4 +21,24 @@ describe("E2E options test - ready callback as option", function () {
             }
         });
     });
+    it("It has public instance bound to `this`", function (done) {
+        browserSync.reset();
+        browserSync({
+            server:   {
+                baseDir: "test/fixtures"
+            },
+            open:     false,
+            logLevel: "silent",
+            callbacks: {
+                ready: function () {
+                    var bs = this;
+                    assert.isFunction(bs.reload);
+                    assert.isFunction(bs.notify);
+                    assert.isFunction(bs.watch);
+                    bs.cleanup();
+                    done();
+                }
+            }
+        });
+    });
 });