Switch to managing online stores by name

Author: alexrudy

protos/feast/core/FeatureView.proto

@@ -72,8 +72,8 @@ message FeatureViewSpec {
     DataSource batch_source = 7;
     // Streaming DataSource from where this view can consume "online" feature data.
     DataSource stream_source = 9;
-    // Online DataSource which can find and rehydrate online features [DISCORD]
-    DataSource online_source = 4701;
+    // Online source name [DISCORD]
+    string online_source = 4701;
 
     // Whether these features should be served online or not
     bool online = 8;

sdk/python/feast/feature_view.py

@@ -85,10 +85,9 @@ class FeatureView(BaseFeatureView):
     ttl: Optional[timedelta]
     batch_source: DataSource
     stream_source: Optional[DataSource]
-    online_source_config: Optional[Any]
     entity_columns: List[Field]
     features: List[Field]
-    online: bool
+    online: Optional[str]
     description: str
     tags: Dict[str, str]
     owner: str
@@ -103,7 +102,7 @@ def __init__(
         schema: Optional[List[Field]] = None,
         entities: List[Entity] = None,
         ttl: Optional[timedelta] = timedelta(days=0),
-        online: Union[bool, DataSource] = True,
+        online: Optional[str] = None,
         description: str = "",
         tags: Optional[Dict[str, str]] = None,
         owner: str = "",
@@ -208,12 +207,8 @@ def __init__(
             tags=tags,
             owner=owner,
         )
-        if isinstance(online, bool):
-            self.online = online
-            warnings.warn(f"FeatureView {self.name} is missing a defined online_store",UserWarning)
-        else:
-            self.online = True
-            self.online_source_config = online
+
+        self.online = online
         self.materialization_intervals = []
 
     def __hash__(self):
@@ -335,12 +330,6 @@ def to_proto(self) -> FeatureViewProto:
             stream_source_proto = self.stream_source.to_proto()
             stream_source_proto.data_source_class_type = f"{self.stream_source.__class__.__module__}.{self.stream_source.__class__.__name__}"
 
-        online_source_proto = None
-        if self.online_source_config:
-            online_source_proto = self.online_source_config.to_proto()
-            online_source_proto.data_source_class_type = f"{self.online_source_config.__class__.__module__}.{self.online_source_config.__class__.__name__}"
-
-
         spec = FeatureViewSpecProto(
             name=self.name,
             entities=self.entities,
@@ -350,10 +339,9 @@ def to_proto(self) -> FeatureViewProto:
             tags=self.tags,
             owner=self.owner,
             ttl=(ttl_duration if ttl_duration is not None else None),
-            online=self.online,
+            online_source=self.online,
             batch_source=batch_source_proto,
             stream_source=stream_source_proto,
-            online_source_proto=online_source_proto
         )
 
         return FeatureViewProto(spec=spec, meta=meta)
@@ -395,19 +383,14 @@ def from_proto(cls, feature_view_proto: FeatureViewProto):
             if feature_view_proto.spec.HasField("stream_source")
             else None
         )
-        online_source = (
-            DataSource.from_proto(feature_view_proto.spec.online_source)
-            if feature_view_proto.spec.HasField("online_source")
-            else None
-        )
 
 
         feature_view = cls(
             name=feature_view_proto.spec.name,
             description=feature_view_proto.spec.description,
             tags=dict(feature_view_proto.spec.tags),
             owner=feature_view_proto.spec.owner,
-            online=online_source or feature_view_proto.spec.online,
+            online=feature_view_proto.spec.online_source,
             ttl=(
                 timedelta(days=0)
                 if feature_view_proto.spec.ttl.ToNanoseconds() == 0

sdk/python/feast/protos/feast/core/FeatureView_pb2.py

@@ -111,10 +111,9 @@ class FeatureViewSpec(google.protobuf.message.Message):
     def stream_source(self) -> feast.core.DataSource_pb2.DataSource:
         """Streaming DataSource from where this view can consume "online" feature data."""
         pass
-    @property
-    def online_source(self) -> feast.core.DataSource_pb2.DataSource:
-        """Online DataSource which can find and rehydrate online features [DISCORD]"""
-        pass
+    online_source: typing.Text = ...
+    """Online source name [DISCORD]"""
+
     online: builtins.bool = ...
     """Whether these features should be served online or not"""
 
@@ -131,10 +130,10 @@ class FeatureViewSpec(google.protobuf.message.Message):
         ttl : typing.Optional[google.protobuf.duration_pb2.Duration] = ...,
         batch_source : typing.Optional[feast.core.DataSource_pb2.DataSource] = ...,
         stream_source : typing.Optional[feast.core.DataSource_pb2.DataSource] = ...,
-        online_source : typing.Optional[feast.core.DataSource_pb2.DataSource] = ...,
+        online_source : typing.Text = ...,
         online : builtins.bool = ...,
         ) -> None: ...
-    def HasField(self, field_name: typing_extensions.Literal["batch_source",b"batch_source","online_source",b"online_source","stream_source",b"stream_source","ttl",b"ttl"]) -> builtins.bool: ...
+    def HasField(self, field_name: typing_extensions.Literal["batch_source",b"batch_source","stream_source",b"stream_source","ttl",b"ttl"]) -> builtins.bool: ...
     def ClearField(self, field_name: typing_extensions.Literal["batch_source",b"batch_source","description",b"description","entities",b"entities","entity_columns",b"entity_columns","features",b"features","name",b"name","online",b"online","online_source",b"online_source","owner",b"owner","project",b"project","stream_source",b"stream_source","tags",b"tags","ttl",b"ttl"]) -> None: ...
 global___FeatureViewSpec = FeatureViewSpec