Skip to content

Commit 05ede36

Browse files
author
Roberto De Ioris
committed
minor fixes
1 parent 45e3574 commit 05ede36

File tree

1 file changed

+27
-25
lines changed

1 file changed

+27
-25
lines changed

Source/UnrealEnginePython/Private/UObject/UEPySequencer.cpp

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ static bool magic_get_frame_number(UMovieScene *MovieScene, PyObject *py_obj, FF
6666
return false;
6767

6868
}
69-
void ImportTransformChannel(const FInterpCurveFloat& Source, FMovieSceneFloatChannel* Dest, FFrameRate DestFrameRate, bool bNegateTangents)
69+
70+
static void ImportTransformChannel(const FInterpCurveFloat& Source, FMovieSceneFloatChannel* Dest, FFrameRate DestFrameRate, bool bNegateTangents)
7071
{
7172
TMovieSceneChannelData<FMovieSceneFloatValue> ChannelData = Dest->GetData();
7273
ChannelData.Reset();
@@ -76,13 +77,13 @@ void ImportTransformChannel(const FInterpCurveFloat& Source, FMovieSceneFloatCha
7677
float ArriveTangent = Source.Points[KeyIndex].ArriveTangent;
7778
if (KeyIndex > 0)
7879
{
79-
ArriveTangent = ArriveTangent / ((Source.Points[KeyIndex].InVal - Source.Points[KeyIndex-1].InVal) * DecimalRate);
80+
ArriveTangent = ArriveTangent / ((Source.Points[KeyIndex].InVal - Source.Points[KeyIndex - 1].InVal) * DecimalRate);
8081
}
81-
82+
8283
float LeaveTangent = Source.Points[KeyIndex].LeaveTangent;
8384
if (KeyIndex < Source.Points.Num() - 1)
8485
{
85-
LeaveTangent = LeaveTangent / ((Source.Points[KeyIndex+1].InVal - Source.Points[KeyIndex].InVal) * DecimalRate);
86+
LeaveTangent = LeaveTangent / ((Source.Points[KeyIndex + 1].InVal - Source.Points[KeyIndex].InVal) * DecimalRate);
8687
}
8788

8889
if (bNegateTangents)
@@ -97,7 +98,8 @@ void ImportTransformChannel(const FInterpCurveFloat& Source, FMovieSceneFloatCha
9798

9899
Dest->AutoSetTangents();
99100
}
100-
bool ImportFBXTransform(FString NodeName, UMovieScene3DTransformSection* TransformSection, UnFbx::FFbxCurvesAPI& CurveAPI)
101+
102+
static bool ImportFBXTransform(FString NodeName, UMovieScene3DTransformSection* TransformSection, UnFbx::FFbxCurvesAPI& CurveAPI)
101103
{
102104

103105

@@ -129,17 +131,17 @@ bool ImportFBXTransform(FString NodeName, UMovieScene3DTransformSection* Transfo
129131
Channels[7]->SetDefault(Scale3D.Y);
130132
Channels[8]->SetDefault(Scale3D.Z);
131133

132-
ImportTransformChannel(Translation[0], Channels[0], FrameRate, false);
133-
ImportTransformChannel(Translation[1], Channels[1], FrameRate, true);
134-
ImportTransformChannel(Translation[2], Channels[2], FrameRate, false);
134+
ImportTransformChannel(Translation[0], Channels[0], FrameRate, false);
135+
ImportTransformChannel(Translation[1], Channels[1], FrameRate, true);
136+
ImportTransformChannel(Translation[2], Channels[2], FrameRate, false);
135137

136138
ImportTransformChannel(EulerRotation[0], Channels[3], FrameRate, false);
137139
ImportTransformChannel(EulerRotation[1], Channels[4], FrameRate, true);
138140
ImportTransformChannel(EulerRotation[2], Channels[5], FrameRate, true);
139141

140-
ImportTransformChannel(Scale[0], Channels[6], FrameRate, false);
141-
ImportTransformChannel(Scale[1], Channels[7], FrameRate, false);
142-
ImportTransformChannel(Scale[2], Channels[8], FrameRate, false);
142+
ImportTransformChannel(Scale[0], Channels[6], FrameRate, false);
143+
ImportTransformChannel(Scale[1], Channels[7], FrameRate, false);
144+
ImportTransformChannel(Scale[2], Channels[8], FrameRate, false);
143145

144146
return true;
145147
}
@@ -1482,7 +1484,7 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
14821484
FTransform DefaultTransform;
14831485
#if ENGINE_MINOR_VERSION >= 18
14841486
CurveAPI.GetConvertedTransformCurveData(NodeName, Translation[0], Translation[1], Translation[2], EulerRotation[0], EulerRotation[1], EulerRotation[2], Scale[0], Scale[1], Scale[2], DefaultTransform);
1485-
#if ENGINE_MINOR_VERSION < 20
1487+
#if ENGINE_MINOR_VERSION < 20
14861488
for (int32 ChannelIndex = 0; ChannelIndex < 3; ++ChannelIndex)
14871489
{
14881490
EAxis::Type ChannelAxis = EAxis::X;
@@ -1498,14 +1500,14 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
14981500
section->GetTranslationCurve(ChannelAxis).SetDefaultValue(DefaultTransform.GetLocation()[ChannelIndex]);
14991501
section->GetRotationCurve(ChannelAxis).SetDefaultValue(DefaultTransform.GetRotation().Euler()[ChannelIndex]);
15001502
section->GetScaleCurve(ChannelAxis).SetDefaultValue(DefaultTransform.GetScale3D()[ChannelIndex]);
1501-
}
1502-
#endif
1503+
}
1504+
#endif
15031505

15041506
#else
15051507
CurveAPI.GetConvertedTransformCurveData(NodeName, Translation[0], Translation[1], Translation[2], EulerRotation[0], EulerRotation[1], EulerRotation[2], Scale[0], Scale[1], Scale[2]);
15061508

15071509
#endif
1508-
#if ENGINE_MINOR_VERSION < 20
1510+
#if ENGINE_MINOR_VERSION < 20
15091511
float MinTime = FLT_MAX;
15101512
float MaxTime = -FLT_MAX;
15111513

@@ -1522,7 +1524,7 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
15221524
else if (ChannelIndex == 2)
15231525
{
15241526
ChannelAxis = EAxis::Z;
1525-
}
1527+
}
15261528

15271529
FInterpCurveFloat* CurveFloat = nullptr;
15281530
FRichCurve* ChannelCurve = nullptr;
@@ -1571,7 +1573,7 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
15711573
if (KeyIndex < CurveFloat->Points.Num() - 1)
15721574
{
15731575
LeaveTangent = LeaveTangent / (CurveFloat->Points[KeyIndex + 1].InVal - CurveFloat->Points[KeyIndex].InVal);
1574-
}
1576+
}
15751577

15761578
if (bNegative)
15771579
{
@@ -1581,22 +1583,22 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
15811583

15821584
FMatineeImportTools::SetOrAddKey(*ChannelCurve, CurveFloat->Points[KeyIndex].InVal, CurveFloat->Points[KeyIndex].OutVal, ArriveTangent, LeaveTangent, CurveFloat->Points[KeyIndex].InterpMode);
15831585

1584-
}
1586+
}
15851587

15861588
ChannelCurve->RemoveRedundantKeys(KINDA_SMALL_NUMBER);
15871589
ChannelCurve->AutoSetTangents();
1590+
}
1591+
}
15881592
}
1589-
}
1590-
}
15911593

1592-
#else
1594+
#else
15931595
ImportFBXTransform(nodename, section, CurveAPI);
1594-
#endif
1596+
#endif
15951597

1596-
#if ENGINE_MINOR_VERSION < 20
1598+
#if ENGINE_MINOR_VERSION < 20
15971599
section->SetStartTime(MinTime);
15981600
section->SetEndTime(MaxTime);
1599-
#endif
1601+
#endif
16001602

16011603
FbxImporter->ReleaseScene();
16021604
ImportOptions->bConvertScene = bConverteScene;
@@ -1610,7 +1612,7 @@ PyObject *py_ue_sequencer_import_fbx_transform(ue_PyUObject *self, PyObject * ar
16101612
ImportOptions->bConvertSceneUnit = bConverteSceneUnit;
16111613
ImportOptions->bForceFrontXAxis = bForceFrontXAxis;
16121614
return PyErr_Format(PyExc_Exception, "unable to find specified node in Fbx file");
1613-
1615+
16141616
}
16151617
#endif
16161618

0 commit comments

Comments
 (0)