Remove length restrictions

Microsoft's compilers are a lot less limited now

Author: rogerbinns

setup.py

@@ -749,31 +749,17 @@ def add_doc(archive, topdir):
 
 def create_c_file(src, dest):
     # Transforms Python src into C dest as a sequence of strings.
-    # Because of the pathetic microsoft compiler we have to break it
-    # up into small chunks
     out = ["/* Automatically generated by setup.py from " + src + " */", ""]
-    percents = 1
-    size = 0
     for line in read_whole_file(src, "rt").split("\n"):
         if "if__name__=='__main__':" in line.replace(" ", ""):
             break
         if line.strip().startswith('#'):  # full line comment
             continue
         if line.strip() == "import apsw":
             continue
-        size = size + len(line)
-        comma = size > 32000
-        if comma:
-            size = 0
-            percents += 1
         line=line.replace("\\", "\\\\").\
               replace('"', '\\"')
         out.append('  "' + line.rstrip() + '\\n"')
-        if comma:
-            out[-1] = out[-1] + ","
-    if out[-1].endswith(","):
-        out[-1] = out[-1][:-1]
-    out[1] = '"%s",' % ("%s" * percents, )
     write_whole_file(dest, "wt", "\n".join(out))
 
 

src/apsw.c

@@ -1933,6 +1933,9 @@ modules etc. For example::
   return NULL;
 }
 
+static const char *apsw_shell_code =
+#include "shell.c"
+    ;
 static void
 add_shell(PyObject *apswmodule)
 {
@@ -1943,22 +1946,13 @@ add_shell(PyObject *apswmodule)
   PyDict_SetItemString(apswdict, "__builtins__", PyDict_GetItemString(maindict, "__builtins__"));
   PyDict_SetItemString(apswdict, "apsw", apswmodule);
 
-  /* the toy compiler from microsoft falls over on string constants
-     bigger than will fit in a 16 bit quantity.  You remember 16 bits?
-     All the rage in the early 1980s.  So we have to compose chunks
-     into a bytes and use that instead.  The format string is as many
-     %s as there are chunks.  It is generated in setup.py.
-  */
-  msvciscrap = PyBytes_FromFormat(
-#include "shell.c"
-  );
-  if (msvciscrap)
-    res = PyRun_StringFlags(PyBytes_AS_STRING(msvciscrap), Py_file_input, apswdict, apswdict, NULL);
-  if (!res)
+  res = PyRun_StringFlags(apsw_shell_code, Py_file_input, apswdict, apswdict, NULL);
+  if (!res) {
     PyErr_Print();
-  assert(res);
-  Py_XDECREF(res);
-  Py_XDECREF(msvciscrap);
+    return;
+  }
+
+  Py_DECREF(res);
 }
 
 #ifdef APSW_TESTFIXTURES