Skip to content

Commit 21d53f1

Browse files
committed
Updated dist files.
1 parent 5fc59dd commit 21d53f1

File tree

5 files changed

+39
-17
lines changed

5 files changed

+39
-17
lines changed

dist/ethers-providers.js

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8062,8 +8062,7 @@ function Web3Signer(provider, address) {
80628062
enumerable: true,
80638063
get: function() {
80648064
throw new Error('unsupported sync operation; use getAddress');
8065-
},
8066-
writable: false
8065+
}
80678066
});
80688067
utils.defineProperty(this, '_syncAddress', false);
80698068
}
@@ -8098,7 +8097,7 @@ utils.defineProperty(Web3Signer.prototype, 'sendTransaction', function(transacti
80988097
var provider = this.provider;
80998098
transaction = JsonRpcProvider._hexlifyTransaction(transaction);
81008099
return this.getAddress().then(function(address) {
8101-
transaction.from = address;
8100+
transaction.from = address.toLowerCase();
81028101
return provider.send('eth_sendTransaction', [ transaction ]).then(function(hash) {
81038102
return new Promise(function(resolve, reject) {
81048103
function check() {
@@ -8121,15 +8120,27 @@ utils.defineProperty(Web3Signer.prototype, 'signMessage', function(message) {
81218120

81228121
var data = ((typeof(message) === 'string') ? utils.toUtf8Bytes(message): message);
81238122
return this.getAddress().then(function(address) {
8124-
return provider.send('eth_sign', [ address, utils.hexlify(data) ]);
8123+
8124+
// https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign
8125+
var method = 'eth_sign';
8126+
var params = [ address.toLowerCase(), utils.hexlify(data) ];
8127+
8128+
// Metamask complains about eth_sign (and on some versions hangs)
8129+
if (provider._web3Provider.isMetaMask) {
8130+
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign
8131+
method = 'personal_sign';
8132+
params = [ utils.hexlify(data), address.toLowerCase() ];
8133+
}
8134+
8135+
return provider.send(method, params);
81258136
});
81268137
});
81278138

81288139
utils.defineProperty(Web3Signer.prototype, 'unlock', function(password) {
81298140
var provider = this.provider;
81308141

81318142
return this.getAddress().then(function(address) {
8132-
return provider.send('personal_unlockAccount', [ address, password, null ]);
8143+
return provider.send('personal_unlockAccount', [ address.toLowerCase(), password, null ]);
81338144
});
81348145
});
81358146

dist/ethers-providers.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/ethers.js

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9641,8 +9641,7 @@ function Web3Signer(provider, address) {
96419641
enumerable: true,
96429642
get: function() {
96439643
throw new Error('unsupported sync operation; use getAddress');
9644-
},
9645-
writable: false
9644+
}
96469645
});
96479646
utils.defineProperty(this, '_syncAddress', false);
96489647
}
@@ -9677,7 +9676,7 @@ utils.defineProperty(Web3Signer.prototype, 'sendTransaction', function(transacti
96779676
var provider = this.provider;
96789677
transaction = JsonRpcProvider._hexlifyTransaction(transaction);
96799678
return this.getAddress().then(function(address) {
9680-
transaction.from = address;
9679+
transaction.from = address.toLowerCase();
96819680
return provider.send('eth_sendTransaction', [ transaction ]).then(function(hash) {
96829681
return new Promise(function(resolve, reject) {
96839682
function check() {
@@ -9700,15 +9699,27 @@ utils.defineProperty(Web3Signer.prototype, 'signMessage', function(message) {
97009699

97019700
var data = ((typeof(message) === 'string') ? utils.toUtf8Bytes(message): message);
97029701
return this.getAddress().then(function(address) {
9703-
return provider.send('eth_sign', [ address, utils.hexlify(data) ]);
9702+
9703+
// https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign
9704+
var method = 'eth_sign';
9705+
var params = [ address.toLowerCase(), utils.hexlify(data) ];
9706+
9707+
// Metamask complains about eth_sign (and on some versions hangs)
9708+
if (provider._web3Provider.isMetaMask) {
9709+
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign
9710+
method = 'personal_sign';
9711+
params = [ utils.hexlify(data), address.toLowerCase() ];
9712+
}
9713+
9714+
return provider.send(method, params);
97049715
});
97059716
});
97069717

97079718
utils.defineProperty(Web3Signer.prototype, 'unlock', function(password) {
97089719
var provider = this.provider;
97099720

97109721
return this.getAddress().then(function(address) {
9711-
return provider.send('personal_unlockAccount', [ address, password, null ]);
9722+
return provider.send('personal_unlockAccount', [ address.toLowerCase(), password, null ]);
97129723
});
97139724
});
97149725

dist/ethers.min.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ethers",
3-
"version": "2.2.1",
3+
"version": "2.2.3",
44
"description": "Ethereum wallet library.",
55
"main": "index.js",
66
"scripts": {
@@ -11,7 +11,7 @@
1111
},
1212
"dependencies": {
1313
"ethers-contracts": "2.2.0",
14-
"ethers-providers": "2.1.17",
14+
"ethers-providers": "2.1.19",
1515
"ethers-utils": "2.1.9",
1616
"ethers-wallet": "2.1.7"
1717
},

0 commit comments

Comments
 (0)