This repository was archived by the owner on Oct 18, 2025. It is now read-only.
Make fcannos.bin platform independent #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file fcannos.bin is a binary Storage of a perl hash, presumably used for speed at some time in the past when this was an issue for guiprep. The problem was when a user was on a different platform, e.g. big-endian/little-endian to the developer who created fcannos.bin. The option to fix Old Englifh then caused an error and processing stopped. This has happened several times over the last few years, so it seems sensible to try to make fcannos.bin platform independent, which I believe it can be if written with `nstore` instead of `store`. Two changes therefore: make fwordgen.pl use `nstore`, and include a copy of the platform-independent version of fcannos.bin Since on a modern computer fwordgen.pl runs very quickly, a longer term solution might be to just include the source dictionary file `2of4brif.txt`, and get guiprep to create its own hash directly from that on startup or when it needs it. This should be sufficient for now, though.
cpeel
reviewed
Dec 21, 2020
fwordgen.pl
Outdated
| use Storable; | ||
| my (%words,%fwords,@multi,$word,$hold,$last,$wt,$ws,$mv,$mmv,$hold1); | ||
|
|
||
| use Storable qw(nstore); |
Member
There was a problem hiding this comment.
Should this replace what is on line 1 instead?
Collaborator
Author
|
Possibly. It was like that with both in an example I saw online but I
should have tried it in place of line 1. I'll give it a try tomorrow.
…On Mon, 21 Dec 2020, 20:50 Casey Peel, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In fwordgen.pl
<#6 (comment)>
:
> @@ -1,6 +1,7 @@
use Storable;
my ***@***.***,$word,$hold,$last,$wt,$ws,$mv,$mmv,$hold1);
+use Storable qw(nstore);
Should this replace what is on line 1 instead?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEGIVKIMHI65DG266HE7T3SV6YKPANCNFSM4VEV5KEQ>
.
|
Collaborator
Author
|
Seems fine with the suggestion you made - thanks. No need for another new version of fscannos.bin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file fcannos.bin is a binary Storage of a perl hash, presumably used for speed at
some time in the past when this was an issue for guiprep. The problem was when a
user was on a different platform, e.g. big-endian/little-endian to the developer who
created fcannos.bin. The option to fix Old Englifh then caused an error and
processing stopped.
This has happened several times over the last few years, so it seems sensible to try
to make fcannos.bin platform independent, which I believe it can be if written with
nstoreinstead ofstore.Two changes therefore: make fwordgen.pl use
nstore, and include a copy of theplatform-independent version of fcannos.bin
Since on a modern computer fwordgen.pl runs very quickly, a longer term solution
might be to just include the source dictionary file
2of4brif.txt, and get guiprepto create its own hash directly from that on startup or when it needs it.
This should be sufficient for now, though, and should fix #5.