Improve memory management of SQLite3Buffer

Replaced the memory buffer that was managed by the SQLite3Buffer with an
instance of the new detail::SQLite3Memory class. This will make the class
copyable and moveable. It's now adhering of the rule of zero.

Author: fr00b0

CppSQLite3.cpp

@@ -191,37 +191,28 @@ CppSQLite3Exception::~CppSQLite3Exception()
 
 ////////////////////////////////////////////////////////////////////////////////
 
-CppSQLite3Buffer::CppSQLite3Buffer()
-{
-    mpBuf = 0;
-}
-
-
-CppSQLite3Buffer::~CppSQLite3Buffer()
-{
-    clear();
-}
-
-
 void CppSQLite3Buffer::clear()
 {
-    if (mpBuf)
-    {
-        sqlite3_free(mpBuf);
-        mpBuf = 0;
-    }
-
+    mBuf.clear();
 }
 
 
 const char* CppSQLite3Buffer::format(const char* szFormat, ...)
 {
     clear();
     va_list va;
-    va_start(va, szFormat);
-    mpBuf = sqlite3_vmprintf(szFormat, va);
-    va_end(va);
-    return mpBuf;
+    try
+    {
+        va_start(va, szFormat);
+        mBuf = detail::SQLite3Memory(szFormat, va);
+        va_end(va);
+        return static_cast<const char*>(mBuf.getBuffer());
+    }
+    catch(CppSQLite3Exception&)
+    {
+        va_end(va);
+        throw;
+    }
 }
 
 

CppSQLite3.h

@@ -87,20 +87,15 @@ class CppSQLite3Exception
 class CppSQLite3Buffer
 {
 public:
-
-    CppSQLite3Buffer();
-
-    ~CppSQLite3Buffer();
-
     const char* format(const char* szFormat, ...);
 
-    operator const char*() { return mpBuf; }
+    operator const char*() { return static_cast<char const*>(mBuf.getBuffer()); }
 
     void clear();
 
 private:
 
-    char* mpBuf;
+    detail::SQLite3Memory mBuf;
 };