Skip to content

Commit 3304a4f

Browse files
committed
Applies multiple ReST markup fixes.
1 parent 407422e commit 3304a4f

8 files changed

+28
-26
lines changed

source/Developer-Guide.rst

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,19 @@ Issues
4545

4646
When filing an issue please make sure to:
4747

48-
* Include enough information for another person to understand the issue.
48+
- Include enough information for another person to understand the issue.
4949
In ROS 2, the following points are needed for narrowing down the cause of an issue. Testing with as many alternatives in each category as feasible will be especially helpful.
50-
- **The operating system and version.** Reasoning: ROS 2 supports multiple platforms, and some bugs are specific to particular versions of operating systems/compilers.
51-
- **The installation method.** Reasoning: Some issues only manifest if ROS 2 has been installed from "fat archives" or from Debians. This can help us determine if the issue is with the packaging process.
52-
- **The specific version of ROS 2.** Reasoning: Some bugs may be present in a particular ROS 2 release and later fixed. It is important to know if your installation includes these fixes.
53-
- **The DDS/RMW implementation being used;** see `this page <Working-with-multiple-RMW-implementations>` for how to determine which one. Reasoning: Communication issues may be specific to the underlying ROS middleware being used.
54-
- **The ROS 2 client library being used.** Reasoning: This helps us narrow down the layer in the stack at which the issue might be.
50+
- **The operating system and version.** Reasoning: ROS 2 supports multiple platforms, and some bugs are specific to particular versions of operating systems/compilers.
51+
- **The installation method.** Reasoning: Some issues only manifest if ROS 2 has been installed from "fat archives" or from Debians. This can help us determine if the issue is with the packaging process.
52+
- **The specific version of ROS 2.** Reasoning: Some bugs may be present in a particular ROS 2 release and later fixed. It is important to know if your installation includes these fixes.
53+
- **The DDS/RMW implementation being used;** see `this page <Working-with-multiple-RMW-implementations>` for how to determine which one. Reasoning: Communication issues may be specific to the underlying ROS middleware being used.
54+
- **The ROS 2 client library being used.** Reasoning: This helps us narrow down the layer in the stack at which the issue might be.
55+
5556
- Include a list of steps to reproduce the issue.
5657
- In case of a bug consider to provide a `short, self contained, correct (compilable), example <http://sscce.org/>`__. Issues are much more likely to be resolved if others can reproduce them easily.
5758
- Mention troubleshooting steps that have been tried already, including:
58-
- Upgrading to the latest version of the code, which may include bug fixes that have not been released yet. Select "building from source" on `this page <Installation#building-from-source>` and follow the instructions to get the "master" branches.
59-
- Trying with a different RMW implementation. See `this page <Working-with-multiple-RMW-implementations>` for how to do that.
59+
- Upgrading to the latest version of the code, which may include bug fixes that have not been released yet. Select "building from source" on `this page <building-from-source>` and follow the instructions to get the "master" branches.
60+
- Trying with a different RMW implementation. See `this page <Working-with-multiple-RMW-implementations>` for how to do that.
6061

6162
Pull requests
6263
^^^^^^^^^^^^^

source/Inter-Sphinx-Support.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ To show all Intersphinx links and their targets of an Intersphinx mapping file,
1515

1616
.. code-block:: bash
1717
18-
python -msphinx.ext.intersphinx url-or-path-to-inv-file
18+
python -msphinx.ext.intersphinx "url-or-path-to-inv-file"
1919
2020
This is helpful when searching for the root cause of a broken Intersphinx link in a documentation project.
2121

@@ -35,7 +35,7 @@ Examples of intersphinx in action
3535

3636
Links to **source code** can be created as follows:
3737

38-
.. code-block:: bash
38+
.. note::
3939

4040
Class :class:`vcstools.VcsClient` implements the :meth:`vcstools.VcsClient.checkout` method.
4141

@@ -45,7 +45,7 @@ Class :class:`vcstools.VcsClient` implements the :meth:`vcstools.VcsClient.check
4545

4646
Links to documentation pages:
4747

48-
.. code-block:: bash
48+
.. note::
4949

5050
Refer to :doc:`vcstools Developer's Guide document<developers_guide>`.
5151

@@ -55,7 +55,7 @@ Refer to :doc:`vcstools Developer's Guide document<developers_guide>`.
5555

5656
Links to other pages in this documentation:
5757

58-
.. code-block:: bash
58+
.. note::
5959

6060
See `the installation page <Installation>`.
6161

source/Migration-Guide.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ There is an equivalent type ``rclcpp::Rate`` object which is basically a drop in
312312
ROS client library
313313
~~~~~~~~~~~~~~~~~~
314314

315-
* `Python Client Library <Migration-Guide-Python.rst>`
315+
* `Python Client Library <Migration-Guide-Python>`
316316
* **NOTE: Others to be written**
317317

318318
Boost

source/OSX-Development-Setup.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ Source the setup file to set the ``NDDSHOME`` environment variable before buildi
199199
The setup file and path will depend on your macOS version.
200200

201201
.. code-block:: bash
202+
202203
# macOS 10.12 Sierra
203204
source /Applications/rti_connext_dds-5.3.1/resource/scripts/rtisetenv_x64Darwin16clang8.0.bash
204205
# macOS 10.13 High Sierra

source/RQt-Overview-Usage.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Users can create their own plugins for RQt with either ``Python`` or ``C++``.
2323
`Over 20 plugins <http://wiki.ros.org/rqt/Plugins>`_ were created in ROS 1 and these plugins are currently being ported to ROS 2 (as of Dec 2018, `more info <https://discourse.ros.org/t/rqt-in-ros2/6428>`_).
2424

2525
Installing From Debian
26-
~~~~~~~~~~~~~~~~~~~~
26+
~~~~~~~~~~~~~~~~~~~~~~
2727

2828
::
2929

@@ -68,6 +68,6 @@ Further Reading
6868
* `RQt for ROS 1 documentation <http://wiki.ros.org/rqt>`_.
6969
* Brief overview of RQt (from `a Willow Garage intern blog post <http://web.archive.org/web/20130518142837/http://www.willowgarage.com/blog/2012/10/21/ros-gui>`_).
7070

71-
.. raw::
71+
.. raw:: html
7272

7373
<iframe width="560" height="315" src="https://www.youtube-nocookie.com/embed/CyP9wHu2PpY" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

source/RQt-Port-Plugin-Windows.rst

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ Microsoft pushed an effort to port much of ROS to Windows, their repos are a goo
1010
They live at the ms-iot organization with branches called init-windows.
1111
For example: https://github.com/ms-iot/qt_gui_core/tree/init_windows
1212

13-
Here is the ROS 2 port of `qt_gui_core <https://github.com/ros-visualization/qt_gui_core/pull/146/commits/c3a9630de6fed3c46684925e7688b6d4c7b8baf8>`_.
13+
Here is the ROS 2 port of `qt_gui_core <https://github.com/ros-visualization/qt_gui_core/pull/146/commits/c3a9630de6fed3c46684925e7688b6d4c7b8baf8>`__.
1414

15-
Here is the ROS 2 port of `python_qt_binding <https://github.com/ros-visualization/python_qt_binding/pull/56>`_.
15+
Here is the ROS 2 port of `python_qt_binding <https://github.com/ros-visualization/python_qt_binding/pull/56>`__.
1616

1717
Considerations for Windows 10
1818
-----------------------------
@@ -24,14 +24,14 @@ I could not successfully use TinyXML.
2424
I upgraded to TinyXML-2 where needed.
2525
It’s a pretty straight forward change.
2626

27-
Checkout `this PR <https://github.com/ros-visualization/qt_gui_core/pull/147>`_ for an example of porting to TinyXML-2.
27+
Checkout `this PR <https://github.com/ros-visualization/qt_gui_core/pull/147>`__ for an example of porting to TinyXML-2.
2828

2929
Code that uses ``__cplusplus`` and code that requires pluginlib
3030
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3131

3232
In some places, notably in the ROS 2 port of pluginlib, there is use of the ``__cplusplus`` flag.
3333
Unfortunately on Windows Visual Studio does not set this flag correctly regardless of the C++ standard that is actually being used.
34-
See `this page <https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=vs-2017>`_ for more information.
34+
See `this page <https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=vs-2017>`__ for more information.
3535

3636
To set it, you need to add the compile option ``/Zc:__cplusplus``.
3737

@@ -55,20 +55,20 @@ On Linux, ``qt_gui_cpp.a`` would be built in:
5555
But on Windows ``qt_gui_cpp.lib`` is built in
5656
<ros2_ws>/build/qt_gui_cpp/src/qt_gui_cpp/Release
5757

58-
For compatibility across platforms in this situation, use `CMake generator expressions <https://cmake.org/cmake/help/v3.5/manual/cmake-generator-expressions.7.html>`_.
58+
For compatibility across platforms in this situation, use `CMake generator expressions <https://cmake.org/cmake/help/v3.5/manual/cmake-generator-expressions.7.html>`__.
5959
However, when you need a library to link against be sure to use ``$<TARGET_LINKER_FILE:_target>`` instead of ``$<TARGET_FILE:_target>``.
6060
The latter will find ``.dll`` files, which cannot be linked against on Windows.
61-
See an `example here <https://github.com/ros-visualization/qt_gui_core/pull/162/files>`_.
61+
See an `example here <https://github.com/ros-visualization/qt_gui_core/pull/162/files>`__.
6262

6363
Compiler and linker flags
6464
~~~~~~~~~~~~~~~~~~~~~~~~~
6565

6666
In general when porting to Windows, many packages might make use of additional compiler flags.
67-
You can find the Windows compiler flags on `Microsoft's documentation <https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-by-category?view=vs-2017>`_.
67+
You can find the Windows compiler flags on `Microsoft's documentation <https://docs.microsoft.com/en-us/cpp/build/reference/compiler-options-listed-by-category?view=vs-2017>`__.
6868
The C++ compiler is called ``cl.exe``.
6969

70-
For linker flags see `Microsoft's documentation <https://docs.microsoft.com/en-us/cpp/build/reference/linker-options?view=vs-2017>`_.
70+
For linker flags see `Microsoft's documentation <https://docs.microsoft.com/en-us/cpp/build/reference/linker-options?view=vs-2017>`__.
7171
The linker program is called ``link.exe``.
7272

7373
However, CMake actually provides many of these options in variables.
74-
This `StackOverflow page <https://stackoverflow.com/questions/9298278/cmake-print-out-all-accessible-variables-in-a-script>`_ contains a good example of how to see all the CMake variables available in a script.
74+
This `StackOverflow page <https://stackoverflow.com/questions/9298278/cmake-print-out-all-accessible-variables-in-a-script>`__ contains a good example of how to see all the CMake variables available in a script.

source/Release-Crystal-Clemmys.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,6 @@ Known Issues
146146
* Cross-vendor communication between rmw_fastrtps_cpp and other implementations is not functioning on Windows (`Issue <https://github.com/ros2/rmw_fastrtps/issues/246>`__)
147147
* 100% CPU usage in Action Server when cancelling a goal from the client. (`Issue <https://github.com/ros2/examples/issues/221>`__)
148148
* Action Server can crash when a goal expires. (`Pull Request <https://github.com/ros2/rcl/pull/360>`__)
149-
* Segfault in `ros2 param get` when a string parameter value contains non-ASCII characters. (`Issue <https://github.com/ros2/ros2cli/issues/176>`__)
149+
* Segfault in ``ros2 param get`` when a string parameter value contains non-ASCII characters. (`Issue <https://github.com/ros2/ros2cli/issues/176>`__)
150150
* The latest version of OpenSplice on Windows is not compatible with the available binaries. (`Issue <https://github.com/ros2/build_cop/issues/157>`__)
151151

source/Releasing-a-ROS-2-package-with-bloom.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ Procedure
6060

6161
Same as in ROS 1: `Following this tutorial <http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease>`__
6262

63-
If porting a ROS 1 package to ROS 2, it's recommended to create a new `-release` repository.
63+
If porting a ROS 1 package to ROS 2, it's recommended to create a new ``-release`` repository.
6464

6565
Build Status
6666
------------

0 commit comments

Comments
 (0)