last update #2

Hammer2900 · 2022-11-04T16:15:31Z

111

* Fix EightPuzzle class implementation * Fix EightPuzzle class implementation (#710) * Address style issues (#710)

* Enhanced explanation of value iteration * Fixed minor typo

* Fixed reset function to reset placeholder variables as well * Added functionality to display best policy

* Add test for TableDrivenVacuumAgent * Debug Travis * Minor fix * Fixed table for TableDrivenAgent * Update README

* Modified table for TableDrivenVacuumAgent * Add learing agent * Add image for learning agent

* Update learning.py * Update test_learning.py

* Added tests for information_content Added some tests for information_content function from learning.py * Added test for information_content

* Update README.md

* Add test for table driven agent * Some style fixes * Added done to tabledrivenagent test in readme * Added randomAgentProgram test to test_agents.py * Added Import randomAgentProgram * Style fixes * Added the done tag tp tabledrivenagent test

* Fixed typos and added inline LaTeX * Fixed more backslashes

* Added mdp_apps notebook * Added images * LaTeX formatting errors fixed

* Add tests for TableDrivenAgentProgram * Add tests for TableDrivenAgentProgram * Check environment status at every step * Check environment status at every step of TableDrivenAgentProgram

* Added pathfinding example * Added images

* Create model classes for backgammon * Add game functions to model * Implement expectiminimax function * Correct logic in some functions * Correct expectiminimax logic * Refactor code and add docstrings * Remove print statements

#1146)

…rch (#1147) * ENH: all problems can now use BS * TST: add test for all types of problems for BS

* Update search.ipynb * Update search.ipynb

…nd fixed NeuralNetLearner and PerceptronLearner (#1163)

* fixed grabbing behaviour in agent * fixed the grabbing issues and itegrated into wumpus environment * cleaned the code a bit * fixing the code space formatting * fixing format

make it clear that the word slot refers to instance attribute, so it won't be confused with __slots__ magic.

* update games.py connect 4 display method original code displays board sideways. Fixed display method to print board bottom down * update games.py add Gomoku game Trivially addition of Gomoku, thanks to flexible implementation of TicTacToe class

…on 3.8 and added svr with r2 and accuracy metrics (#1185)

* MinMax Player Added a MiniMax PLayer * Changed OP

* Revert "reformulated the map coloring problem" This reverts commit 20ab0e5. * Revert "fixed typo errors and removed unnecessary brackets" This reverts commit f743146. * Revert "added map coloring SAT problems" This reverts commit 9e0fa55. * Revert "removed useless doctest for AC4 in Sudoku because AC4's tests are already present in test_csp.py" This reverts commit b3cd24c. * Revert "added doctest in Sudoku for AC4 and and the possibility of choosing the constant propagation algorithm in mac inference" This reverts commit 6986247. * Revert "added the mentioned AC4 algorithm for constraint propagation" This reverts commit 03551fb. * added map coloring SAT problem * fixed build error * Revert "added map coloring SAT problem" This reverts commit 93af259. * Revert "fixed build error" This reverts commit 6641c2c. * added map coloring SAT problem * removed redundant parentheses * added Viterbi algorithm * added monkey & bananas planning problem * simplified condition in search.py * added tests for monkey & bananas planning problem * removed monkey & bananas planning problem * Revert "removed monkey & bananas planning problem" This reverts commit 9d37ae0. * Revert "added tests for monkey & bananas planning problem" This reverts commit 24041e9. * Revert "simplified condition in search.py" This reverts commit 6d229ce. * Revert "added monkey & bananas planning problem" This reverts commit c74933a. * defined the PlanningProblem as a specialization of a search.Problem & fixed typo errors * fixed doctest in logic.py * fixed doctest for cascade_distribution * added ForwardPlanner and tests * added __lt__ implementation for Expr * added more tests * renamed forward planner * Revert "renamed forward planner" This reverts commit c4139e5. * renamed forward planner class & added doc * added backward planner and tests * fixed mdp4e.py doctests * removed ignore_delete_lists_heuristic flag * fixed heuristic for forward and backward planners * added SATPlan and tests * fixed ignore delete lists heuristic in forward and backward planners * fixed backward planner and added tests * updated doc * added nary csp definition and examples * added CSPlan and tests * fixed CSPlan * added book's cryptarithmetic puzzle example * fixed typo errors in test_csp * fixed #1111 * added sortedcontainers to yml and doc to CSPlan * added tests for n-ary csp * fixed utils.extend * updated test_probability.py * converted static methods to functions * added AC3b and AC4 with heuristic and tests * added conflict-driven clause learning sat solver * added tests for cdcl and heuristics * fixed probability.py * fixed import * fixed kakuro * added Martelli and Montanari rule-based unification algorithm * removed duplicate standardize_variables * renamed variables known as built-in functions * fixed typos in learning.py * renamed some files and fixed typos * fixed typos * fixed typos * fixed tests * removed unify_mm * remove unnecessary brackets * fixed tests * moved utility functions to utils.py * fixed typos * moved utils function to utils.py, separated probability learning classes from learning.py, fixed typos and fixed imports in .ipynb files * added missing learners * fixed Travis build * fixed typos * fixed typos * fixed typos * fixed typos * fixed typos in agents files * fixed imports in agent files * fixed deep learning .ipynb imports * fixed typos * added SVM * added .ipynb and fixed typos * adapted code for .ipynb * fixed typos * updated .ipynb * updated .ipynb * updated logic.py * updated .ipynb * updated .ipynb * updated planning.py * updated inf definition * fixed typos * fixed typos * fixed typos * fixed typos * Revert "fixed typos" This reverts commit 658309d. * Revert "fixed typos" This reverts commit 08ad660. * fixed typos * fixed typos * fixed typos * fixed typos * fixed typos and utils imports in *4e.py files * fixed typos * fixed typos * fixed typos * fixed typos * fixed import * fixed typos * fixed typos * fixd typos * fixed typos * fixed typos * updated SVM * added svm test * fixed SVM and tests * fixed some definitions and typos * fixed svm and tests * added SVMs also in learning4e.py * fixed inf definition * fixed .travis.yml * fixed .travis.yml * fixed import * fixed inf definition * replaced cvxopt with qpsolvers * replaced cvxopt with quadprog * fixed some definitions * fixed typos and removed unnecessary tests * replaced quadprog with qpsolvers * fixed extend in utils * specified error type in try-catch block * fixed extend in utils * fixed typos * fixed learning.py * fixed doctest errors * added comments * removed unnecessary if condition * updated learning.py * fixed imports * removed unnecessary imports * fixed keras imports * fixed typos * fixed learning_curve * added comments * fixed typos * removed inf and isclose definition from utils and replaced with numpy.inf and numpy.isclose * fixed doctests * fixed numpy imports * fixed superclass call * removed utils import from 4e py file * removed unnecessary norm function in utils and fixed Activation definition * removed unnecessary clip function * removed unnecessary import and functions from utils * added tests and fxed some functions * fixed doc * fixed typos in gui folder * removed unnecessary Keras classes and updated pytest.ini * fixed some details * readded Keras classes * fixed import * fixed some parameters * removed unnecessary superclass * fixed neural net * added LinearLearner, LogisticLearner with tests and fixed NeuralNetLearner and PerceptronLearner * removed random_weights and substituted with np.random.uniform * fixed imports * Revert "fixed imports" This reverts commit aaf9c7b. * Revert "removed random_weights and substituted with np.random.uniform" This reverts commit 70d662b. * revert * fixed typo * fixed .ini and DecisionTreeLearner * fixed tests * removed main and fixed AutoencoderLearner * revert NeuralNetLearner and PerceptronLearner definition * fixed all tests and removed Learner class * fixed tests * fixed tests * fixed tests * fixed some function definition * fixed verbose definition * fixed tests * fixed tests * fixed tests * updated .travis.yml * fixed .travis.yml * fixed .travis.yml * fixed all tests * fixed requirements.txt * fixed .travis.yml * update .travis.yml * rollback .travis.yml * rollback tests * fixed output layer with softmax as activation function * updated yml * updated requirements.txt * fixed svc * fixed syntax warns * fixed syntax warns * removed 3.8 * added python 3.8 support * fixed doctests * fixed spaces and doctest * added SVR with r2 and accuracy metrics * fixed imports * fixed tests * removed not allowed imports * fixed * fixed keras * fixed * updated requirements.txt

…aph_search_for_vis method (#1242)

sourcery-ai · 2022-11-04T16:16:29Z

Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 2.86%.

Quality metrics	Before	After	Change
Complexity	6.99 ⭐	8.46 ⭐	1.47 👎
Method Length	56.23 ⭐	64.57 🙂	8.34 👎
Working memory	5.50 ⭐	6.21 🙂	0.71 👎
Quality	70.71% 🙂	67.85% 🙂	-2.86% 👎

Other metrics	Before	After	Change
Lines	11012	15925	4913

Changed files	Quality Before	Quality After	Quality Change
agents.py	77.89% ⭐	79.03% ⭐	1.14% 👍
csp.py	65.72% 🙂	54.60% 🙂	-11.12% 👎
games.py	67.77% 🙂	68.78% 🙂	1.01% 👍
ipyviews.py	85.19% ⭐	85.19% ⭐	0.00%
knowledge.py	72.86% 🙂	72.05% 🙂	-0.81% 👎
learning.py	66.93% 🙂	63.55% 🙂	-3.38% 👎
logic.py	58.02% 🙂	55.18% 🙂	-2.84% 👎
mdp.py	74.68% 🙂	66.42% 🙂	-8.26% 👎
nlp.py	76.68% ⭐	76.62% ⭐	-0.06% 👎
notebook.py	49.75% 😞	48.87% 😞	-0.88% 👎
planning.py	56.04% 🙂	58.74% 🙂	2.70% 👍
probability.py	77.17% ⭐	77.51% ⭐	0.34% 👍
search.py	70.32% 🙂	69.75% 🙂	-0.57% 👎
text.py	84.04% ⭐	84.16% ⭐	0.12% 👍
utils.py	90.37% ⭐	91.28% ⭐	0.91% 👍
tests/test_agents.py	84.42% ⭐	73.77% 🙂	-10.65% 👎
tests/test_csp.py	75.79% ⭐	68.91% 🙂	-6.88% 👎
tests/test_games.py	81.65% ⭐	83.09% ⭐	1.44% 👍
tests/test_knowledge.py	67.82% 🙂	77.26% ⭐	9.44% 👍
tests/test_learning.py	83.94% ⭐	84.47% ⭐	0.53% 👍
tests/test_logic.py	86.56% ⭐	84.09% ⭐	-2.47% 👎
tests/test_mdp.py	88.17% ⭐	71.44% 🙂	-16.73% 👎
tests/test_nlp.py	85.07% ⭐	84.86% ⭐	-0.21% 👎
tests/test_planning.py	82.98% ⭐	78.71% ⭐	-4.27% 👎
tests/test_probability.py	72.87% 🙂	74.67% 🙂	1.80% 👍
tests/test_search.py	80.48% ⭐	74.71% 🙂	-5.77% 👎
tests/test_text.py	67.33% 🙂	67.48% 🙂	0.15% 👍
tests/test_utils.py	82.34% ⭐	87.29% ⭐	4.95% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
csp.py	Zebra	68 ⛔	342 ⛔		5.15% ⛔	Refactor to reduce nesting. Try splitting into smaller methods
learning.py	BackPropagationLearner	43 ⛔	593 ⛔	23 ⛔	7.50% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
logic.py	unit_propagation	48 ⛔	331 ⛔		9.19% ⛔	Refactor to reduce nesting. Try splitting into smaller methods
planning.py	PlanningProblem.expand_actions	74 ⛔	326 ⛔	16 ⛔	10.89% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
csp.py	Kakuro.__init__	76 ⛔	312 ⛔	16 ⛔	11.20% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

antmarakis and others added 30 commits February 22, 2018 20:02

Update search.ipynb (#726)

2c90244

Fix EightPuzzle class implementation in search.py (#710) (#733)

3c56362

* Fix EightPuzzle class implementation * Fix EightPuzzle class implementation (#710) * Address style issues (#710)

Modified table for TableDrivenVacuumAgent (#738)

25e4193

Enhanced explanation of value iteration (#736)

516eff0

* Enhanced explanation of value iteration * Fixed minor typo

Minor enhancement to grid_mdp editor (#734)

a6edaa1

* Fixed reset function to reset placeholder variables as well * Added functionality to display best policy

Fix #731: Add table and tests for TableDrivenVacuumAgent (#732)

195708d

* Add test for TableDrivenVacuumAgent * Debug Travis * Minor fix * Fixed table for TableDrivenAgent * Update README

Update text.py (#740)

8dbf924

Fix #741: Add learning agent to vacuum_world.ipynb (#742)

3092089

* Modified table for TableDrivenVacuumAgent * Add learing agent * Add image for learning agent

Learning: Neural Net Test + Minor Styling Fix (#746)

eae217b

* Update learning.py * Update test_learning.py

Fix various typos. (#750)

06af67e

Added tests for information_content (#753)

ae4f1cf

* Added tests for information_content Added some tests for information_content function from learning.py * Added test for information_content

Added Node in search.ipynb (#761)

1e96cd1

fixing build

35c9673

Update README.md (#767)

c67fb65

Minor update in search.ipynb (#763)

1b65fec

Update nlp_apps.ipynb (#764)

4f6c716

Updated README.md (#771)

7d3c37b

* Update README.md

Update SUBMODULE.md

ac04a20

added Done tag for adaboost (#774)

6cac365

csp.ipynb: removed some typos (#769)

f5d4793

Update README.md

84586ce

Update README.md (#773)

5f72783

Fixed typos and added inline LaTeX to mdp.ipynb (#776)

657a511

* Fixed typos and added inline LaTeX * Fixed more backslashes

Added mdp_apps notebook (#778)

5285177

* Added mdp_apps notebook * Added images * LaTeX formatting errors fixed

Minor fix in typo (#779)

751a286

Minor typos (#780)

cc2d405

Added TableDrivenAgentProgram tests (#777)

7e763e6

* Add tests for TableDrivenAgentProgram * Add tests for TableDrivenAgentProgram * Check environment status at every step * Check environment status at every step of TableDrivenAgentProgram

Enhanced mdp_apps notebook (#782)

d1f162b

* Added pathfinding example * Added images

Backgammon implementation (#783)

d6a175c

* Create model classes for backgammon * Add game functions to model * Implement expectiminimax function * Correct logic in some functions * Correct expectiminimax logic * Refactor code and add docstrings * Remove print statements

Antzelino and others added 27 commits January 4, 2020 16:57

cd into aima folder before installing requirements (#1143)

22dd82c

removed unnecessary imports and substituted clip function with np.clip (

ec2111a

#1146)

[WIP] ENH: add support for all types of problems in Bidirectional Sea…

69b6a46

…rch (#1147) * ENH: all problems can now use BS * TST: add test for all types of problems for BS

type in ga section

2ebdc41

fixed typos in gui folder (#1150)

1b24e0d

removed apostrophe

7e5c1d6

Update Optimizer and Backpropagation.ipynb (#1168)

076556a

Search.ipynb (#1167)

70f4e82

* Update search.ipynb * Update search.ipynb

added LinearRegressionLearner, LogisticRegressionLearner with tests a…

918168c

…nd fixed NeuralNetLearner and PerceptronLearner (#1163)

trying to fix keras issue

c431efe

dropping the acceptable error rate values

e5663e4

Update README.md

d2d3f31

Image Rendering problem resolved (#1178)

dcaa880

relaxing test thresholds

dae3e4d

Typos at search.ipynb (#1179)

43b5cb9

relaxing tests some more...

677308e

fixed grabbing behaviour in agent (#1148)

f502be9

* fixed grabbing behaviour in agent * fixed the grabbing issues and itegrated into wumpus environment * cleaned the code a bit * fixing the code space formatting * fixing format

Fix misspelled variable.

746477a

update doc-string of Agent class (#1187)

82da1c3

make it clear that the word slot refers to instance attribute, so it won't be confused with __slots__ magic.

add chapter 7-10 (#1096)

62a5a30

games.py Gomoku (#1080)

5aeaf61

* update games.py connect 4 display method original code displays board sideways. Fixed display method to print board bottom down * update games.py add Gomoku game Trivially addition of Gomoku, thanks to flexible implementation of TicTacToe class

Imported utils4e to resolve some dependency bugs (#1186)

ca301ea

fixed svm for not posdef kernel matrix, updated .travis.yml with Pyth…

a4d9389

…on 3.8 and added svr with r2 and accuracy metrics (#1185)

Added a MinMax Player (#1184)

6baf56e

* MinMax Player Added a MiniMax PLayer * Changed OP

Update README.md

668a2fb

Fixed bug in treatment of repeated nodes in frontier in best_first_gr…

61d695b

…aph_search_for_vis method (#1242)

Hammer2900 merged commit 0833b7f into Hammer2900:master Nov 4, 2022

sourcery-ai bot mentioned this pull request Nov 4, 2022

last update (Sourcery refactored) #3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

last update #2

last update #2

Uh oh!

Hammer2900 commented Nov 4, 2022

Uh oh!

sourcery-ai bot commented Nov 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

61 participants

last update #2

last update #2

Uh oh!

Conversation

Hammer2900 commented Nov 4, 2022

Uh oh!

sourcery-ai bot commented Nov 4, 2022

Sourcery Code Quality Report

Legend and Explanation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

61 participants