Skip to content

Commit d492ec8

Browse files
Merge branch 'TheOdinProject:main' into thatblindgeye-patch-2
2 parents dd08621 + 0dc37ec commit d492ec8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
<!-- Complete the following REQUIRED checkboxes by replacing the whitespace between the square brackets with an 'x', e.g. [x]. -->
44
- [ ] I have thoroughly read and understand the [CSS Exercises Contributing Guide](https://github.com/TheOdinProject/css-exercises/blob/main/CONTRIBUTING.md)
5-
- [ ] The title of this PR is in `file/exercise/folder: brief description of changes` format e.g. `01 flex center: add hint for XYZ`
5+
- [ ] The title of this PR is similar to the `file, exercise/lesson, or folder: brief description of changes` format e.g. `01 flex center: add hint for XYZ`
66

77
<!-- Complete the following checkboxes only if they are applicable to your PR. You can complete these later if they are not currently applicable. -->
88
- [ ] If one exists, I have linked a related open issue to this PR in Step 2 below

grid/01-grid-layout-1/README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
Now it's time to practice the Grid tools we've learned and create a layout that might seem familiar. We're going to make a Holy Grail Layout like the ones we created using Flexbox. The difference here is that we won't be relying on Flexbox for this exercise. We'll only be using Grid. You'll be able to see the benefits of Grid for yourself!
44

55
### Hints
6+
67
- You only need to add to the CSS selectors
78
- Look back to the Creating a Grid lesson if you forget how to turn an element into a grid
89
- Use fixed track sizes (e.g. pixels) for your columns and rows
@@ -12,10 +13,11 @@ Now it's time to practice the Grid tools we've learned and create a layout that
1213
![desired outcome](./desired-outcome.png)
1314

1415
### Self Check
16+
1517
- The gap is 15px
1618
- The grid has two columns
1719
- The grid has four rows
18-
- The first column is three times larger than the other
20+
- The second column is three times larger than the first
1921
- The third row is five times larger than the others
2022
- The header and footer elements span across both columns
2123
- The sidebar element only spans across the first column

0 commit comments

Comments
 (0)