Skip to content

Commit eded47f

Browse files
committed
Bug#32815725 PB2: NDB.NDB_RESTORE_CONV_NULL IS FAILING IN DEVBLD RUNS FOR 8.0 AND TRUNK [2/2]
Fix test case ndb.ndb_restore_conv_null. Now ndb_restore fails with existatus 1. Change-Id: I8bb6a27a94141486b8752f0434f26e20beaccdcf
1 parent e98f863 commit eded47f

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

mysql-test/suite/ndb/r/ndb_restore_conv_null.result

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,11 @@ col2 varchar(20),
6767
col3 text,
6868
col4 date) engine=ndb;
6969
Cause backup stall
70+
7071
Starting backup
7172
Backup started
7273
update nullable set col2=NULL;
74+
7375
Waiting for backup to complete
7476
Backup completed
7577
drop table nullable;

mysql-test/suite/ndb/t/ndb_restore_conv_null.test

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -69,23 +69,23 @@ create table not_nullable_no_nulls (
6969

7070
--echo # cannot restore nullable->non-nullable without --lossy-conversions
7171
--error 1
72-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_no_nulls $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
72+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_no_nulls $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
7373

7474
--echo # can restore nullable->non-nullable if non-nullable col has no NULL values
75-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_no_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
76-
--exec $NDB_RESTORE -b $the_backup_id -n 2 -r --include-tables=test.nullable_no_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
75+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_no_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
76+
--exec $NDB_RESTORE -b $the_backup_id -n 2 -r --include-tables=test.nullable_no_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
7777

7878
--echo # cannot restore nullable->non-nullable if non-nullable col has NULL values
79-
--error 139
80-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_with_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
79+
--error 1
80+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable_with_nulls --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
8181

8282
--echo # cannot restore not-null->non-nullable without --promote-attributes
8383
--error 1
84-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.not_nullable_no_nulls $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
84+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.not_nullable_no_nulls $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
8585

8686
--echo # can restore not-null->nullable
87-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.not_nullable_no_nulls --promote-attributes $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
88-
--exec $NDB_RESTORE -b $the_backup_id -n 2 -r --include-tables=test.not_nullable_no_nulls --promote-attributes $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
87+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.not_nullable_no_nulls --promote-attributes $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
88+
--exec $NDB_RESTORE -b $the_backup_id -n 2 -r --include-tables=test.not_nullable_no_nulls --promote-attributes $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
8989

9090
select count(*) from nullable_no_nulls where col2=REPEAT("abcde", 4) and col3=REPEAT("XYZ", 2000) and col4="2021-04-01";
9191
select count(*) from nullable_with_nulls;
@@ -114,13 +114,13 @@ while ($i)
114114
--enable_query_log
115115

116116
--echo Cause backup stall
117-
--exec $NDB_MGM --ndb-connectstring="$NDB_CONNECTSTRING" -e "all error 10039" >> $NDB_TOOLS_OUTPUT 2&>1
117+
--exec $NDB_MGM -e "all error 10039"
118118

119119
--source suite/ndb/t/ndb_backup_nowait_start.inc
120120

121121
update nullable set col2=NULL;
122122

123-
--exec $NDB_MGM --ndb-connectstring="$NDB_CONNECTSTRING" -e "all error 0" >> $NDB_TOOLS_OUTPUT 2&>1
123+
--exec $NDB_MGM -e "all error 0"
124124
--source suite/ndb/t/ndb_backup_nowait_wait.inc
125125

126126
drop table nullable;
@@ -134,8 +134,8 @@ create table nullable (
134134
col4 date not null)engine=ndb;
135135

136136
--echo # cannot restore nullable->non-nullable if backup log sets NULL values
137-
--error 139
138-
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2&>1
137+
--error 1
138+
--exec $NDB_RESTORE -b $the_backup_id -n 1 -r --include-tables=test.nullable --lossy-conversions $NDB_BACKUPS-$the_backup_id >> $NDB_TOOLS_OUTPUT 2>&1
139139

140140
select * from nullable;
141141

0 commit comments

Comments
 (0)