Wrap ConfigOrigin.comments in unmodifiableList

havocp · havocp · commit e1d59dc48cb0 · 2014-02-19T11:31:33.000-05:00
This prevents people from messing with the returned list.
diff --git a/config/src/main/java/com/typesafe/config/impl/SimpleConfigOrigin.java b/config/src/main/java/com/typesafe/config/impl/SimpleConfigOrigin.java
@@ -221,7 +221,7 @@ public int lineNumber() {
     @Override
     public List<String> comments() {
         if (commentsOrNull != null) {
-            return commentsOrNull;
+            return Collections.unmodifiableList(commentsOrNull);
         } else {
             return Collections.emptyList();
         }

Original file line number	Diff line number	Diff line change
`@@ -221,7 +221,7 @@ public int lineNumber() {`
`221`	`221`	`@Override`
`222`	`222`	`public List<String> comments() {`
`223`	`223`	`if (commentsOrNull != null) {`
`224`		`- return commentsOrNull;`
	`224`	`+ return Collections.unmodifiableList(commentsOrNull);`
`225`	`225`	`} else {`
`226`	`226`	`return Collections.emptyList();`
`227`	`227`	`}`