Request response workspace (awslabs#664)

Co-authored-by: Bret Ambrose <[email protected]>

Author: bretambrose

.clang-tidy

@@ -1,5 +1,5 @@
 ---
-Checks:          'clang-diagnostic-*,clang-analyzer-*,readability-*,modernize-*,bugprone-*,misc-*,google-runtime-int,llvm-header-guard,fuchsia-restrict-system-includes,-clang-analyzer-valist.Uninitialized,-clang-analyzer-security.insecureAPI.rand,-clang-analyzer-alpha.*,-readability-magic-numbers,-readability-non-const-parameter'
+Checks:          'clang-diagnostic-*,clang-analyzer-*,readability-*,modernize-*,bugprone-*,misc-*,google-runtime-int,llvm-header-guard,fuchsia-restrict-system-includes,-clang-analyzer-valist.Uninitialized,-clang-analyzer-security.insecureAPI.rand,-clang-analyzer-alpha.*,-readability-magic-numbers,-readability-non-const-parameter,-modernize-use-trailing-return-type'
 WarningsAsErrors: '*'
 HeaderFilterRegex: '.*(?<!cJSON.cpp)$'
 FormatStyle: 'file'

include/aws/crt/Variant.h

@@ -404,6 +404,7 @@ namespace Aws
             {
                 template <typename AlternativeT> void operator()(AlternativeT &&value) const
                 {
+                    (void)value;
                     using PlaintT = typename std::remove_reference<AlternativeT>::type;
                     value.~PlaintT();
                 }

include/aws/crt/mqtt/Mqtt5Client.h

@@ -435,6 +435,8 @@ namespace Aws
 
                 virtual ~Mqtt5Client();
 
+                struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept;
+
               private:
                 Mqtt5Client(const Mqtt5ClientOptions &options, Allocator *allocator = ApiAllocator()) noexcept;
 

include/aws/crt/mqtt/MqttConnection.h

@@ -263,7 +263,7 @@ namespace Aws
                 bool Disconnect() noexcept;
 
                 /// @private
-                aws_mqtt_client_connection *GetUnderlyingConnection() noexcept;
+                aws_mqtt_client_connection *GetUnderlyingConnection() const noexcept;
 
                 /**
                  * Subscribes to topicFilter. OnMessageReceivedHandler will be invoked from an event-loop

include/aws/crt/mqtt/private/Mqtt5ClientCore.h

@@ -109,6 +109,8 @@ namespace Aws
 
                 virtual ~Mqtt5ClientCore();
 
+                struct aws_mqtt5_client *GetUnderlyingHandle() const noexcept { return m_client; }
+
               private:
                 Mqtt5ClientCore(const Mqtt5ClientOptions &options, Allocator *allocator = ApiAllocator()) noexcept;
 

include/aws/crt/mqtt/private/MqttConnectionCore.h

@@ -151,7 +151,7 @@ namespace Aws
                 bool Disconnect() noexcept;
 
                 /// @private
-                aws_mqtt_client_connection *GetUnderlyingConnection() noexcept;
+                aws_mqtt_client_connection *GetUnderlyingConnection() const noexcept;
 
                 /**
                  * @internal