Add onnx-openvino #2264
Draft
Add onnx-openvino #2264
+139
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borg323
reviewed
Aug 25, 2025
Comment on lines
+41
to
+47
| #if __has_include("CL/opencl.hpp") | ||
| #include "CL/opencl.hpp" | ||
| #elif __has_include("OpenCL/opencl.hpp") | ||
| #include "OpenCL/opencl.hpp" | ||
| #else | ||
| #include "opencl.hpp" | ||
| #endif |
Member
There was a problem hiding this comment.
This should be guarded by a #if __has_include("CL/opencl.h") and should define a USE_OPENVINO or USE_OPECL symbol to exclude the code that will fail to build otherwise.
Also OpenCL/opencl.hpp is only for apple systems AFAIK, does openvino support them?
Contributor
Author
There was a problem hiding this comment.
Yes, it should be supported by apple but that was not my intent here.
src/neural/backends/network_onnx.cc
Outdated
| } | ||
| case OnnxProvider::OPENVINO: { | ||
| auto ocl_instance = std::make_shared<OpenCL>(); | ||
| cl_context opencl_context = ocl_instance->context_.get(); |
Contributor
Author
There was a problem hiding this comment.
No. its optional. When you don't want to use cl_context that is.
Member
There was a problem hiding this comment.
Then make it conditional on USE_OPENCL defined earlier in the file if __has_include("CL/opencl.h") is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds openvino for intel igpu's, may be useful for igpu's that don't support sycl(e,g intel 10th gen and below).
This supports: