Skip to content

Commit 1a682cf

Browse files
committed
Merge branch 'release/1.4.3'
2 parents 82f23ac + 04bbbed commit 1a682cf

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

CHANGELOG

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## 更新记录
22

3+
### fir-cli 1.4.3
4+
- 修复 @build_cmd 中的输出显示, 使用 `$?` 获取 Process::Status
5+
36
### fir-cli 1.4.2
47
- 修复手动提交 zip 格式符号表文件报错的 bug
58

@@ -82,7 +85,7 @@
8285

8386
### fir-cli 1.1.7
8487
- 增加符号表上传指令, `fir mapping(alias m)`
85-
- 有一下三种方式上传符号表(目前已经支持 dSYM 和 txt 两种格式的符号表文件上传)
88+
- 有以下三种方式上传符号表(目前已经支持 dSYM 和 txt 两种格式的符号表文件上传)
8689
- 1. 指定 version 和 build 上传: `fir m <mapping file path> -P <bughd project id> -v <app version> -b <app build> -T <your api token>`
8790
- 2. 在 publish 的时候自动上传: `fir p <app file path> -m <mapping file path> -P <bughd project id> -T <your api token>`
8891
- 3. 在 build_ipa 的时候自动上传: `fir b <project dir> -P <bughd project id> -M -p -T <your api token>`

fir-cli.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ Gem::Specification.new do |spec|
2727
/_/ /___/_/ |_| \____/_____/___/
2828
2929
## 更新记录
30-
### fir-cli 1.4.2
31-
- 修复手动提交 zip 格式符号表文件报错的 bug
30+
### fir-cli 1.4.3
31+
- 修复 @build_cmd 中的输出显示, 使用 `$?` 获取 Process::Status
3232
- 支持远程 git 项目打包编译, enjoy.
3333
- `$ fir bi/ba <git ssh url> -B develop -c <changelog> -p`
3434
- 详细更新记录, 请查看: https://github.com/FIRHQ/fir-cli/blob/master/CHANGELOG

lib/fir/util/build_common.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,9 @@ def logger_info_and_run_build_command
6565
logger.info 'Building......'
6666
logger_info_dividing_line
6767

68-
status = system(@build_cmd)
68+
logger.info `#{@build_cmd}`
6969

70-
unless status
70+
if $?.to_i != 0
7171
logger.error 'Build failed'
7272
exit 1
7373
end

lib/fir/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# encoding: utf-8
22

33
module FIR
4-
VERSION = '1.4.2'
4+
VERSION = '1.4.3'
55
end

0 commit comments

Comments
 (0)