Skip to content

Commit b4e0ac6

Browse files
authored
Merge pull request eugenp#11584 from hkhan/JAVA-8679-fix-module-test
[JAVA-8679] Fix test for JDK 17
2 parents 2d4b1cb + e550897 commit b4e0ac6

File tree

1 file changed

+19
-17
lines changed

1 file changed

+19
-17
lines changed

core-java-modules/core-java-9-jigsaw/src/test/java/com/baeldung/java9/modules/ModuleAPIUnitTest.java

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,21 @@
22

33
import static org.hamcrest.CoreMatchers.is;
44
import static org.hamcrest.CoreMatchers.nullValue;
5-
import static org.hamcrest.Matchers.*;
5+
6+
import static org.hamcrest.MatcherAssert.assertThat;
7+
import static org.hamcrest.Matchers.hasItem;
8+
import static org.hamcrest.Matchers.hasItems;
69
import static org.hamcrest.collection.IsEmptyCollection.empty;
7-
import static org.junit.Assert.*;
10+
import static org.junit.Assert.assertFalse;
11+
import static org.junit.Assert.assertTrue;
812

913
import java.lang.module.ModuleDescriptor;
10-
import java.lang.module.ModuleDescriptor.*;
14+
15+
import java.lang.module.ModuleDescriptor.Builder;
16+
import java.lang.module.ModuleDescriptor.Exports;
17+
import java.lang.module.ModuleDescriptor.Opens;
18+
import java.lang.module.ModuleDescriptor.Provides;
19+
import java.lang.module.ModuleDescriptor.Requires;
1120
import java.sql.Date;
1221
import java.sql.Driver;
1322
import java.util.HashMap;
@@ -16,7 +25,7 @@
1625

1726
import org.junit.Before;
1827
import org.junit.Test;
19-
import org.junit.Ignore;
28+
2029

2130
public class ModuleAPIUnitTest {
2231

@@ -28,14 +37,9 @@ public class ModuleAPIUnitTest {
2837

2938
@Before
3039
public void setUp() {
31-
Class<HashMap> hashMapClass = HashMap.class;
32-
javaBaseModule = hashMapClass.getModule();
33-
34-
Class<Date> dateClass = Date.class;
35-
javaSqlModule = dateClass.getModule();
36-
37-
Class<Person> personClass = Person.class;
38-
module = personClass.getModule();
40+
javaBaseModule = HashMap.class.getModule();
41+
javaSqlModule = Date.class.getModule();
42+
module = Person.class.getModule();
3943
}
4044

4145
@Test
@@ -111,7 +115,6 @@ public void givenModules_whenAccessingModuleDescriptorRequires_thenRequiresAreRe
111115
}
112116

113117
@Test
114-
@Ignore // fixing in http://team.baeldung.com/browse/JAVA-8679
115118
public void givenModules_whenAccessingModuleDescriptorProvides_thenProvidesAreReturned() {
116119
Set<Provides> javaBaseProvides = javaBaseModule.getDescriptor().provides();
117120
Set<Provides> javaSqlProvides = javaSqlModule.getDescriptor().provides();
@@ -120,7 +123,7 @@ public void givenModules_whenAccessingModuleDescriptorProvides_thenProvidesAreRe
120123
.map(Provides::service)
121124
.collect(Collectors.toSet());
122125

123-
assertThat(javaBaseProvidesService, contains("java.nio.file.spi.FileSystemProvider"));
126+
assertThat(javaBaseProvidesService, hasItem("java.nio.file.spi.FileSystemProvider"));
124127
assertThat(javaSqlProvides, empty());
125128
}
126129

@@ -132,15 +135,14 @@ public void givenModules_whenAccessingModuleDescriptorExports_thenExportsAreRetu
132135
.map(Exports::source)
133136
.collect(Collectors.toSet());
134137

135-
assertThat(javaSqlExportsSource, hasItems("java.sql", "javax.sql"));
138+
assertThat(javaSqlExportsSource, hasItems("java.sql", "javax.sql"));
136139
}
137140

138141
@Test
139142
public void givenModules_whenAccessingModuleDescriptorUses_thenUsesAreReturned() {
140-
Set<String> javaBaseUses = javaBaseModule.getDescriptor().uses();
141143
Set<String> javaSqlUses = javaSqlModule.getDescriptor().uses();
142144

143-
assertThat(javaSqlUses, contains("java.sql.Driver"));
145+
assertThat(javaSqlUses, hasItem("java.sql.Driver"));
144146
}
145147

146148
@Test

0 commit comments

Comments
 (0)