-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Correct grammar in roles and permissions documentation #127538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@boliu83 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ef58d6e: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects grammar in the Virtual WAN roles and permissions documentation.
- Rewrites a sentence for clarity around required permissions for associating route maps.
- Removes unnecessary hyphenation in "out-bound" to "outbound".
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| If you want to associate an inbound or out-bound route map is associated with the Virtual Network connection, you need an additional permission: | ||
| To associate an inbound or outbound route map with a Virtual Network connection, you must have an additional permission: | ||
|
|
||
| * Read the route map(s) that is applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read). |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar issue: 'route map(s) that is applied' mixes plural with singular. Consider revising to either 'Read the route map applied to the Virtual Network connection' (if singular) or 'Read the route maps that are applied to the Virtual Network connection.'
| * Read the route map(s) that is applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read). | |
| * Read the route maps that are applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read). |
|
#sign-off |
|
@siddomala - Some of the content in this PR would benefit from a copy edit. After the PR is merged to the default branch, an editor will contact the listed author. |
Correct grammar in roles and permissions documentation