Skip to content

Conversation

@boliu83
Copy link
Contributor

@boliu83 boliu83 commented Aug 26, 2025

Correct grammar in roles and permissions documentation

@prmerger-automator
Copy link
Contributor

@boliu83 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ef58d6e:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-wan/roles-permissions.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards
Copy link
Contributor

@siddomala

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Aug 26, 2025
@v-dirichards v-dirichards requested a review from Copilot October 16, 2025 21:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects grammar in the Virtual WAN roles and permissions documentation.

  • Rewrites a sentence for clarity around required permissions for associating route maps.
  • Removes unnecessary hyphenation in "out-bound" to "outbound".

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

If you want to associate an inbound or out-bound route map is associated with the Virtual Network connection, you need an additional permission:
To associate an inbound or outbound route map with a Virtual Network connection, you must have an additional permission:

* Read the route map(s) that is applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read).
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar issue: 'route map(s) that is applied' mixes plural with singular. Consider revising to either 'Read the route map applied to the Virtual Network connection' (if singular) or 'Read the route maps that are applied to the Virtual Network connection.'

Suggested change
* Read the route map(s) that is applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read).
* Read the route maps that are applied to the Virtual Network connection (Microsoft.Network/virtualHubs/routeMaps/read).

Copilot uses AI. Check for mistakes.
@siddomala
Copy link
Contributor

#sign-off

@ShannonLeavitt
Copy link
Contributor

@siddomala - Some of the content in this PR would benefit from a copy edit. After the PR is merged to the default branch, an editor will contact the listed author.

@ShannonLeavitt ShannonLeavitt merged commit a80828a into MicrosoftDocs:main Oct 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants