Skip to content

Conversation

@hdamecharla
Copy link
Contributor

This pull request makes minor updates to the disk configuration examples in the documentation to ensure consistency in property naming. Specifically, it changes the property names for disk IOPS and throughput from kebab-case to snake_case.

  • Documentation consistency:
    • Updated disk configuration property names from disk-iops-read-write and disk-mbps-read-write to disk_iops_read_write and disk_mbps_read_write in two code examples within articles/sap/automation/configure-extra-disks.md. [1] [2]
      Use the correct property names when setting disk IOPS and throughtput (MBPS) numbers

User the correct property names when setting disk IOPS and throughtput (MBPS) numbers
@prmerger-automator
Copy link
Contributor

@hdamecharla : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 6c5ca0a:

✅ Validation status: passed

File Status Preview URL Details
articles/sap/automation/configure-extra-disks.md ✅Succeeded

For more details, please refer to the build report.

@ttorble ttorble requested a review from Copilot October 8, 2025 14:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes property naming conventions in disk configuration examples within SAP automation documentation. The changes standardize disk IOPS and throughput property names from kebab-case to snake_case format.

  • Updated disk configuration property names from kebab-case to snake_case format
  • Corrected disk-iops-read-write to disk_iops_read_write and disk-mbps-read-write to disk_mbps_read_write

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ttorble
Copy link
Contributor

ttorble commented Oct 8, 2025

@KimForss

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Oct 8, 2025
@KimForss
Copy link
Contributor

KimForss commented Oct 9, 2025

#sign-off

@ttorble ttorble merged commit bf49794 into MicrosoftDocs:main Oct 9, 2025
2 checks passed
@hdamecharla hdamecharla deleted the patch-1 branch October 18, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants