-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Update WAF rules and support information #127733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aligning FAQ documentation with CRS/DRS Ruleset that outlines that CRS 3.0 is no longer supported; DRS2.1 and CRS3.2 are recommended as the latest available versions, with all available features
|
@BrandynR-MSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
@BrandynR-MSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit afc5147:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/web-application-firewall/ag/application-gateway-waf-faq.yml | Details |
articles/web-application-firewall/ag/application-gateway-waf-faq.yml
- Line 47, Column 61: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#drs-21' in 'articles/web-application-firewall/ag/application-gateway-crs-rulegroups-rules.md', did you mean '#drs21'?
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Web Application Firewall (WAF) FAQ documentation to reflect current support for rule sets. The update removes CRS 3.0 from supported versions and adds DRS 2.1 as a recommended option.
- Removes CRS 3.0 from the list of currently supported rule sets
- Adds DRS 2.1 as a supported rule set option
- Updates deprecation notice to include CRS 3.0 alongside CRS 2.2.9
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
articles/web-application-firewall/ag/application-gateway-waf-faq.yml
Outdated
Show resolved
Hide resolved
articles/web-application-firewall/ag/application-gateway-waf-faq.yml
Outdated
Show resolved
Hide resolved
halkazwini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @BrandynR-MSFT!
Please commit these two small changes.
|
@BrandynR-MSFT - Can you respond to the requested changes or let us know if you would like us to commit them?
@halkazwini - When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
…aq.yml Co-authored-by: Hussein Al Kazwini <[email protected]>
…aq.yml Co-authored-by: Hussein Al Kazwini <[email protected]>
BrandynR-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepted changes
|
Learn Build status updates of commit 5182617: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
Learn Build status updates of commit 953ad99: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
#sign-off |
Aligning FAQ documentation with CRS/DRS Ruleset that outlines that CRS 3.0 is no longer supported; DRS2.1 and CRS3.2 are recommended as the latest available versions, with all available features