Support running nds_power over spark connect #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <[email protected]>
|
Hi @eordentlich, @jihoonson, please help review it. thx very much. |
firestarman
reviewed
Oct 31, 2025
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
So will this plugin use the version defined by <maven.compiler.source> and <maven.compiler.target> ? I saw you removed the relevatn configs.
| execution_time_list: a list recording query execution time. | ||
| """ | ||
| spark_app_id = spark_session.sparkContext.applicationId | ||
| spark_app_id = spark_session.conf.get("spark.app.id") |
There was a problem hiding this comment.
Does the spark.app.id config always exist ?
| 'query': query_name, | ||
| } | ||
|
|
||
| def _is_above_spark_4(self): |
There was a problem hiding this comment.
nit:
Suggested change
| def _is_above_spark_4(self): | |
| def _is_spark_400_or_later(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SparkContext and Py4j are unavailable in the Spark Connect environment. This PR tries best to use consistent code to achieve the same functionality across both classic Spark and Spark Connect modes.
I ran the CPU and GPU tests separately on Spark 3.5.1, Spark 4.0.0 (classic), and Spark 4.0.0 (Connect), with all tests passing.