changed up my logging slightly.

Author: talam

nycpython/frontend/home.py

@@ -1,7 +1,5 @@
 """The NYC Python home page."""
 
-import logging
-
 from flask import Blueprint, current_app, render_template
 
 from nycpython.meetup import APIWrapper
@@ -21,13 +19,8 @@ def index():
     """Return the home page."""
     group_id = current_app.config.get('MEETUP_GROUP_ID')
     api_key = current_app.config.get('MEETUP_API_KEY')
-    try:
-        api = APIWrapper(api_key)
-        events = api.events(group_id)
-        photos = api.photos(group_id, 5)
-    except (ValueError, Exception):
-        logging.warning('Meetup API didn\'t return anything')
-        events = []
-        photos = []
+    api = APIWrapper(api_key)
+    events = api.events(group_id)
+    photos = api.photos(group_id, 5)
 
     return render_template('home/index.html', events=events, photos=photos)

nycpython/meetup/__init__.py

@@ -2,14 +2,30 @@
 
 from datetime import datetime
 import json
-import logging
 
 import redis
 import requests
 
+from nycpython.utils import create_logger
+
 __all__ = 'events', 'photos'
 
-_logger = logging.getLogger(__name__)
+meetup_api_logger = create_logger(__name__)
+
+
+# def api_error_logger(api, method, response):
+#     _logger.error('{}'.format(api, method, response))
+#
+
+class APIException(Exception):
+
+    """Base Error logging class for the Meetup's API error messages exceptions."""
+
+    def __init__(self, method, error_type, response):
+        pass
+
+    def __str__(self):
+        pass
 
 
 class APIWrapper:
@@ -20,9 +36,8 @@ def __init__(self, api_key):
         self.api_key = api_key
 
     def _get(self, method, limit, **params):
-        r = redis.StrictRedis()
+        #r = redis.StrictRedis()
         key = 'meetup_{}_{}'.format(method, limit)
-
         result = None and r.get(key)
         if not result:
             url = 'http://api.meetup.com/2/{}.json'.format(method)
@@ -31,14 +46,14 @@ def _get(self, method, limit, **params):
 
             resp = requests.get(url, params=params)
             if resp.status_code != 200:
-                _logger.error('Meetup API <{}>: {}'.format(
+                meetup_api_logger.error('Meetup API <{}>: {}'.format(
                     resp.status_code, resp.json().get('details')))
-                raise Exception('Meetup returned no results for {}'.format(method))
+                meetup_api_logger.error('Meetup returned no results for {}'.format(method))
 
             result = resp.json().get('results', [])
 
-            r.set(key, json.dumps(result))
-            r.expire(key, 300)
+            #r.set(key, json.dumps(result))
+            #r.expire(key, 300)
         else:
             result = json.loads(result)
 

nycpython/utils.py

@@ -2,6 +2,7 @@
 
 import importlib
 import pkgutil
+import logging
 
 from flask import Blueprint
 
@@ -26,3 +27,8 @@ def register_blueprints(app, package_name, package_path):
             item = getattr(m, x)
             if isinstance(item, Blueprint):
                 app.register_blueprint(item)
+
+
+def create_logger(name):
+    _logger = logging.getLogger(name)
+    return _logger