Skip to content

Commit 063a41f

Browse files
authored
[Rust] No need to use mut iter (krahets#1356)
* No need to use mut iter * Update iter
1 parent ebff1cc commit 063a41f

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

codes/rust/chapter_sorting/bucket_sort.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ fn bucket_sort(nums: &mut [f64]) {
1212
let k = nums.len() / 2;
1313
let mut buckets = vec![vec![]; k];
1414
// 1. 将数组元素分配到各个桶中
15-
for &mut num in &mut *nums {
15+
for &num in nums.iter() {
1616
// 输入数据范围为 [0, 1),使用 num * k 映射到索引范围 [0, k-1]
1717
let i = (num * k as f64) as usize;
1818
// 将 num 添加进桶 i
@@ -25,8 +25,8 @@ fn bucket_sort(nums: &mut [f64]) {
2525
}
2626
// 3. 遍历桶合并结果
2727
let mut i = 0;
28-
for bucket in &mut buckets {
29-
for &mut num in bucket {
28+
for bucket in buckets.iter() {
29+
for &num in bucket.iter() {
3030
nums[i] = num;
3131
i += 1;
3232
}

codes/rust/chapter_sorting/counting_sort.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ include!("../include/include.rs");
1010
// 简单实现,无法用于排序对象
1111
fn counting_sort_naive(nums: &mut [i32]) {
1212
// 1. 统计数组最大元素 m
13-
let m = *nums.into_iter().max().unwrap();
13+
let m = *nums.iter().max().unwrap();
1414
// 2. 统计各数字的出现次数
1515
// counter[num] 代表 num 的出现次数
1616
let mut counter = vec![0; m as usize + 1];
17-
for &num in &*nums {
17+
for &num in nums.iter() {
1818
counter[num as usize] += 1;
1919
}
2020
// 3. 遍历 counter ,将各元素填入原数组 nums
@@ -31,16 +31,16 @@ fn counting_sort_naive(nums: &mut [i32]) {
3131
// 完整实现,可排序对象,并且是稳定排序
3232
fn counting_sort(nums: &mut [i32]) {
3333
// 1. 统计数组最大元素 m
34-
let m = *nums.into_iter().max().unwrap();
34+
let m = *nums.iter().max().unwrap() as usize;
3535
// 2. 统计各数字的出现次数
3636
// counter[num] 代表 num 的出现次数
37-
let mut counter = vec![0; m as usize + 1];
38-
for &num in &*nums {
37+
let mut counter = vec![0; m + 1];
38+
for &num in nums.iter() {
3939
counter[num as usize] += 1;
4040
}
4141
// 3. 求 counter 的前缀和,将“出现次数”转换为“尾索引”
4242
// 即 counter[num]-1 是 num 在 res 中最后一次出现的索引
43-
for i in 0..m as usize {
43+
for i in 0..m {
4444
counter[i + 1] += counter[i];
4545
}
4646
// 4. 倒序遍历 nums ,将各元素填入结果数组 res
@@ -53,9 +53,7 @@ fn counting_sort(nums: &mut [i32]) {
5353
counter[num as usize] -= 1; // 令前缀和自减 1 ,得到下次放置 num 的索引
5454
}
5555
// 使用结果数组 res 覆盖原数组 nums
56-
for i in 0..n {
57-
nums[i] = res[i];
58-
}
56+
nums.copy_from_slice(&res)
5957
}
6058

6159
/* Driver Code */

0 commit comments

Comments
 (0)