mbedtls: fix __pkcs11_crypto_mbedtls_cerificate_is_issuer()

syzzer · alonbl · commit f6bf05bc3a5a · 2016-12-08T22:19:46.000+02:00
Entire branch is missing if certificate is issuer.

Signed-off-by: Steffan Karger &lt;steffan@karger.me&gt;
diff --git a/ChangeLog b/ChangeLog
@@ -5,6 +5,7 @@ $Id$
 
 ????-??-?? - Version 1.21
 
+ * mbedtls: fix missing logic if issur certificate, thanks to Steffan Karger
 
 2016-12-08 - Version 1.20
 
diff --git a/lib/_pkcs11h-crypto-mbedtls.c b/lib/_pkcs11h-crypto-mbedtls.c
@@ -197,7 +197,9 @@ __pkcs11h_crypto_mbedtls_certificate_is_issuer (
 	}
 
 	if ( 0 == x509_crt_verify(&x509_cert, &x509_issuer, NULL, NULL,
-		&verify_flags, NULL, NULL ))
+		&verify_flags, NULL, NULL )) {
+		is_issuer = TRUE;
+	}
 
 cleanup:
 	x509_crt_free(&x509_cert);

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ $Id$`
`5`	`5`
`6`	`6`	`????-??-?? - Version 1.21`
`7`	`7`
	`8`	`+ * mbedtls: fix missing logic if issur certificate, thanks to Steffan Karger`
`8`	`9`
`9`	`10`	`2016-12-08 - Version 1.20`
`10`	`11`
Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,9 @@ __pkcs11h_crypto_mbedtls_certificate_is_issuer (`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`if ( 0 == x509_crt_verify(&x509_cert, &x509_issuer, NULL, NULL,`
`200`		`- &verify_flags, NULL, NULL ))`
	`200`	`+ &verify_flags, NULL, NULL )) {`
	`201`	`+ is_issuer = TRUE;`
	`202`	`+ }`
`201`	`203`
`202`	`204`	`cleanup:`
`203`	`205`	`x509_crt_free(&x509_cert);`