Skip to content
This repository was archived by the owner on May 17, 2023. It is now read-only.

Commit 778b75d

Browse files
PelsinPelsin
authored
More clean up of incorrect props that shows warnings. (#54)
1 parent 151dca8 commit 778b75d

File tree

3 files changed

+23
-44
lines changed

3 files changed

+23
-44
lines changed

‎src/Pages/AddonsConfigPage.js‎

Lines changed: 22 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ const verifyAndSavePS4 = async () => {
126126
setTimeout(checkRead, 1000);
127127
} else {
128128
// Make sure our signature is 256 bytes
129-
if ( signature.length != 256 || serial.length != 16) {
129+
if ( signature.length !== 256 || serial.length !== 16) {
130130
throw new Error("Signature or serial is invalid");
131131
}
132132
try {
@@ -534,9 +534,7 @@ export default function AddonsConfigPage() {
534534
{({
535535
handleSubmit,
536536
handleChange,
537-
handleBlur,
538537
values,
539-
touched,
540538
errors,
541539
}) => (
542540
<Form noValidate onSubmit={handleSubmit}>
@@ -565,8 +563,7 @@ export default function AddonsConfigPage() {
565563
label="Enabled"
566564
type="switch"
567565
id="BootselButtonAddonButton"
568-
reverse="true"
569-
error={undefined}
566+
reverse
570567
isInvalid={false}
571568
checked={Boolean(values.BootselButtonAddonEnabled)}
572569
onChange={(e) => { handleCheckbox("BootselButtonAddonEnabled", values); handleChange(e);}}
@@ -592,8 +589,7 @@ export default function AddonsConfigPage() {
592589
label="Enabled"
593590
type="switch"
594591
id="BoardLedAddonButton"
595-
reverse="true"
596-
error={undefined}
592+
reverse
597593
isInvalid={false}
598594
checked={Boolean(values.BoardLedAddonEnabled)}
599595
onChange={(e) => {handleCheckbox("BoardLedAddonEnabled", values); handleChange(e);}}
@@ -635,8 +631,7 @@ export default function AddonsConfigPage() {
635631
label="Enabled"
636632
type="switch"
637633
id="AnalogInputButton"
638-
reverse="true"
639-
error={undefined}
634+
reverse
640635
isInvalid={false}
641636
checked={Boolean(values.AnalogInputEnabled)}
642637
onChange={(e) => {handleCheckbox("AnalogInputEnabled", values); handleChange(e);}}
@@ -700,7 +695,6 @@ export default function AddonsConfigPage() {
700695
type="switch"
701696
id="ShmupMode"
702697
className="col-sm-3 ms-2"
703-
error={undefined}
704698
isInvalid={false}
705699
checked={Boolean(values.shmupMode)}
706700
onChange={(e) => {handleCheckbox("shmupMode", values); handleChange(e);}}
@@ -877,8 +871,7 @@ export default function AddonsConfigPage() {
877871
label="Enabled"
878872
type="switch"
879873
id="TurboInputButton"
880-
reverse="true"
881-
error={undefined}
874+
reverse
882875
isInvalid={false}
883876
checked={Boolean(values.TurboInputEnabled)}
884877
onChange={(e) => {handleCheckbox("TurboInputEnabled", values); handleChange(e);}}
@@ -919,8 +912,7 @@ export default function AddonsConfigPage() {
919912
label="Enabled"
920913
type="switch"
921914
id="JSliderInputButton"
922-
reverse="true"
923-
error={undefined}
915+
reverse
924916
isInvalid={false}
925917
checked={Boolean(values.JSliderInputEnabled)}
926918
onChange={(e) => {handleCheckbox("JSliderInputEnabled", values); handleChange(e);}}
@@ -1011,8 +1003,7 @@ export default function AddonsConfigPage() {
10111003
label="Enabled"
10121004
type="switch"
10131005
id="ReverseInputButton"
1014-
reverse="true"
1015-
error={undefined}
1006+
reverse
10161007
isInvalid={false}
10171008
checked={Boolean(values.ReverseInputEnabled)}
10181009
onChange={(e) => {handleCheckbox("ReverseInputEnabled", values); handleChange(e);}}
@@ -1089,8 +1080,7 @@ export default function AddonsConfigPage() {
10891080
label="Enabled"
10901081
type="switch"
10911082
id="I2CAnalog1219InputButton"
1092-
reverse="true"
1093-
error={undefined}
1083+
reverse
10941084
isInvalid={false}
10951085
checked={Boolean(values.I2CAnalog1219InputEnabled)}
10961086
onChange={(e) => {handleCheckbox("I2CAnalog1219InputEnabled", values); handleChange(e);}}
@@ -1182,8 +1172,7 @@ export default function AddonsConfigPage() {
11821172
label="Enabled"
11831173
type="switch"
11841174
id="DualDirectionalInputButton"
1185-
reverse="true"
1186-
error={undefined}
1175+
reverse
11871176
isInvalid={false}
11881177
checked={Boolean(values.DualDirectionalInputEnabled)}
11891178
onChange={(e) => {handleCheckbox("DualDirectionalInputEnabled", values); handleChange(e);}}
@@ -1224,8 +1213,7 @@ export default function AddonsConfigPage() {
12241213
label="Enabled"
12251214
type="switch"
12261215
id="BuzzerSpeakerAddonButton"
1227-
reverse="true"
1228-
error={undefined}
1216+
reverse
12291217
isInvalid={false}
12301218
checked={Boolean(values.BuzzerSpeakerAddonEnabled)}
12311219
onChange={(e) => {handleCheckbox("BuzzerSpeakerAddonEnabled", values); handleChange(e);}}
@@ -1266,8 +1254,7 @@ export default function AddonsConfigPage() {
12661254
label="Enabled"
12671255
type="switch"
12681256
id="ExtraButtonAddonButton"
1269-
reverse="true"
1270-
error={undefined}
1257+
reverse
12711258
isInvalid={false}
12721259
checked={Boolean(values.ExtraButtonAddonEnabled)}
12731260
onChange={(e) => { handleCheckbox("ExtraButtonAddonEnabled", values); handleChange(e);}}
@@ -1297,8 +1284,7 @@ export default function AddonsConfigPage() {
12971284
label="Enabled"
12981285
type="switch"
12991286
id="PlayerNumAddonButton"
1300-
reverse="true"
1301-
error={undefined}
1287+
reverse
13021288
isInvalid={false}
13031289
checked={Boolean(values.PlayerNumAddonEnabled)}
13041290
onChange={(e) => {handleCheckbox("PlayerNumAddonEnabled", values); handleChange(e);}}
@@ -1375,8 +1361,7 @@ export default function AddonsConfigPage() {
13751361
label="Enabled"
13761362
type="switch"
13771363
id="SliderSOCDInputButton"
1378-
reverse="true"
1379-
error={undefined}
1364+
reverse
13801365
isInvalid={false}
13811366
checked={Boolean(values.SliderSOCDInputEnabled)}
13821367
onChange={(e) => {handleCheckbox("SliderSOCDInputEnabled", values); handleChange(e);}}
@@ -1390,27 +1375,27 @@ export default function AddonsConfigPage() {
13901375
<h2>!!!! DISCLAIMER: GP2040-CE WILL NEVER SUPPLY THESE FILES !!!!</h2>
13911376
<p>Please upload the 3 required files and click the "Verify & Save" button to use PS4 Mode.</p>
13921377
</Row>
1393-
<Row class="mb-3">
1394-
<div class="col-sm-3 mb-3">
1378+
<Row className="mb-3">
1379+
<div className="col-sm-3 mb-3">
13951380
Private Key (PEM):
13961381
<input type="file" id="ps4key-input" accept="*/*" />
13971382
</div>
1398-
<div class="col-sm-3 mb-3">
1383+
<div className="col-sm-3 mb-3">
13991384
Serial Number (16 Bytes in Hex Ascii):
14001385
<input type="file" id="ps4serial-input" accept="*/*" />
14011386
</div>
1402-
<div class="col-sm-3 mb-3">
1387+
<div className="col-sm-3 mb-3">
14031388
Signature (256 Bytes in Binary):
14041389
<input type="file" id="ps4signature-input" accept="*/*" />
14051390
</div>
14061391
</Row>
1407-
<Row class="mb-3">
1408-
<div class="col-sm-3 mb-3">
1392+
<Row className="mb-3">
1393+
<div className="col-sm-3 mb-3">
14091394
<Button type="button" onClick={verifyAndSavePS4}>Verify & Save</Button>
14101395
</div>
14111396
</Row>
1412-
<Row class="mb-3">
1413-
<div class="col-sm-3 mb-3">
1397+
<Row className="mb-3">
1398+
<div className="col-sm-3 mb-3">
14141399
<span id="ps4alert"></span>
14151400
</div>
14161401
</Row>
@@ -1419,8 +1404,7 @@ export default function AddonsConfigPage() {
14191404
label="Enabled"
14201405
type="switch"
14211406
id="PS4ModeAddonEnabledButton"
1422-
reverse="true"
1423-
error={undefined}
1407+
reverse
14241408
isInvalid={false}
14251409
checked={Boolean(values.PS4ModeAddonEnabled)}
14261410
onChange={(e) => {handleCheckbox("PS4ModeAddonEnabled", values); handleChange(e);}}

‎src/Pages/BackupPage.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ export default function BackupPage() {
214214
}}
215215
>
216216
<Button
217-
type={"save"}
217+
type="submit"
218218
onClick={handleSave}
219219
>
220220
{"Save"}
@@ -225,7 +225,6 @@ export default function BackupPage() {
225225
paddingLeft: 24,
226226
fontWeight: 600,
227227
color: "darkcyan",
228-
textJustify: "center",
229228
alignSelf: "center"
230229
}}
231230
>
@@ -264,7 +263,6 @@ export default function BackupPage() {
264263
}}
265264
>
266265
<Button
267-
type={"load"}
268266
onClick={() => {
269267
inputFileSelect.current.click();
270268
}}
@@ -277,7 +275,6 @@ export default function BackupPage() {
277275
paddingLeft: 24,
278276
fontWeight: 600,
279277
color: "darkcyan",
280-
textJustify: "center",
281278
alignSelf: "center"
282279
}}
283280
>

‎src/Pages/SettingsPage.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,7 @@ export default function SettingsPage() {
108108
{({
109109
handleSubmit,
110110
handleChange,
111-
handleBlur,
112111
values,
113-
touched,
114112
errors,
115113
}) => console.log('errors', errors) || (
116114
<div>

0 commit comments

Comments
 (0)