Add validation for Helm charts to prevent develop image from being published

Signed-off-by: Willem Pienaar <[email protected]>

Author: woop

.github/workflows/release.yml

@@ -111,8 +111,10 @@ jobs:
           project_id: ${{ secrets.GCP_PROJECT_ID }}
           service_account_key: ${{ secrets.GCP_SA_KEY }}
       - run: gcloud auth configure-docker --quiet
-      - name: Validate chart versions
+      - name: Validate repository versions
         run: make lint-versions
+      - name: Validate chart release versions
+        run: ./infra/scripts/validate-helm-chart-docker-image.sh
       - name: Remove previous Helm
         run: sudo rm -rf $(which helm)
       - name: Install Helm

infra/scripts/validate-helm-chart-docker-image.sh

@@ -0,0 +1,37 @@
+#!/usr/bin/env bash
+
+# Get project root
+PROJECT_ROOT_DIR=$(git rev-parse --show-toplevel)
+
+# Should have no "develop" tags
+grep -R "tag: develop" "$PROJECT_ROOT_DIR"/infra/charts || true
+COUNT=$(grep -R "tag: develop" "$PROJECT_ROOT_DIR"/infra/charts | wc -l)
+
+if [ "$COUNT" -gt 0 ]; then
+  echo 'Found more than one instance of "develop" in an image tag. Please replace with correct release version.';
+  exit 1
+else
+  echo 'No "develop" tags found, continuing';
+fi
+
+# Should have no "gcr" images
+grep -R "gcr.io" "$PROJECT_ROOT_DIR"/infra/charts || true
+COUNT=$(grep -R "gcr.io" "$PROJECT_ROOT_DIR"/infra/charts | wc -l)
+
+if [ "$COUNT" -gt 0 ]; then
+  echo 'Found more than one instance of "gcr.io" in charts. Please replace with https://hub.docker.com/r/feastdev feast image.';
+  exit 1
+else
+  echo 'No "gcr.io" instances found, continuing';
+fi
+
+# Should have no "SNAPSHOT" versions
+grep -R "SNAPSHOT" "$PROJECT_ROOT_DIR"/infra/charts || true
+COUNT=$(grep -R "SNAPSHOT" "$PROJECT_ROOT_DIR"/infra/charts | wc -l)
+
+if [ "$COUNT" -gt 0 ]; then
+  echo 'Found more than one instance of "SNAPSHOT" in charts. Please ensure that no SNAPSHOT charts are published.';
+  exit 1
+else
+  echo 'No "SNAPSHOT" instances found, continuing';
+fi