Made config writing blocking

Author: jacobtread

src/config.rs

@@ -17,6 +17,7 @@ pub fn config_path() -> PathBuf {
     parent.join(CONFIG_FILE_NAME)
 }
 
+/// Reads the [`ClientConfig`] from the config file if one is present
 pub fn read_config_file() -> Option<ClientConfig> {
     let file_path = config_path();
     if !file_path.exists() {
@@ -44,7 +45,9 @@ pub fn read_config_file() -> Option<ClientConfig> {
     Some(config)
 }
 
-pub async fn write_config_file(config: ClientConfig) {
+/// Writes the provided `config` to the config file, this will create a new
+/// file if one is not present
+pub fn write_config_file(config: ClientConfig) {
     let file_path = config_path();
     let bytes = match serde_json::to_vec(&config) {
         Ok(value) => value,
@@ -54,7 +57,7 @@ pub async fn write_config_file(config: ClientConfig) {
         }
     };
     debug!("Writing config file");
-    if let Err(err) = tokio::fs::write(file_path, bytes).await {
+    if let Err(err) = std::fs::write(file_path, bytes) {
         show_error("Failed to save client config", &err.to_string());
     }
 }

src/ui/iced.rs

@@ -56,8 +56,6 @@ enum AppMessage {
     LookupState(LookupState),
     /// The remember checkbox button has changed
     RememberChanged(bool),
-    /// Message that doesn't do anything
-    Noop,
 }
 
 /// Different states that lookup process can be in
@@ -139,8 +137,6 @@ impl Application for App {
 
             // Lookup result changed
             AppMessage::LookupState(value) => {
-                let mut command = Command::none();
-
                 if let LookupState::Success(value) = &value {
                     // Start all the servers
                     start_all_servers(self.http_client.clone(), value.url.clone());
@@ -149,20 +145,15 @@ impl Application for App {
                     if self.remember {
                         let connection_url = value.url.to_string();
 
-                        command = Command::perform(
-                            write_config_file(ClientConfig { connection_url }),
-                            |_| AppMessage::Noop,
-                        )
+                        write_config_file(ClientConfig { connection_url });
                     }
                 }
 
                 self.lookup_result = value;
-                return command;
             }
 
             // Remember value changed
             AppMessage::RememberChanged(value) => self.remember = value,
-            AppMessage::Noop => {}
         }
         Command::none()
     }

src/ui/native.rs

@@ -139,9 +139,8 @@ impl App {
                 // Save the connection URL
                 if remember {
                     let connection_url = result.url.to_string();
-                    tokio::spawn(async move {
-                        write_config_file(ClientConfig { connection_url }).await;
-                    });
+
+                    write_config_file(ClientConfig { connection_url });
                 }
 
                 let text = format!(