Merge pull request #4022 from ProvableHQ/release-mainnet-4.4.0

[Release] Mainnet 4.4.0

Author: vicsn

.cargo/audit.toml

@@ -5,4 +5,6 @@ ignore = [
   "RUSTSEC-2024-0436",
   # TODO find a suitable replacement for fxhash.
   "RUSTSEC-2025-0057",
+  # TODO remove once newer versions of tracing-sbuscriber support colored logs again.
+  "RUSTSEC-2025-0055",
 ]

.ci/devnet_ci.sh

@@ -50,7 +50,7 @@ trap 'echo "⛔️ Error in $BASH_SOURCE at line $LINENO: \"$BASH_COMMAND\" fail
 # Flags used by all ndoes
 common_flags=(
   --nodisplay --nobanner --noupdater "--network=$network_id" --verbosity=1
-  --allow-external-peers "--dev-num-validators=$total_validators"
+  "--dev-num-validators=$total_validators"
 )
 
 # Start all validator nodes in the background
@@ -134,7 +134,8 @@ done
 
 # Creates a test program.
 mkdir -p program
-echo "program test_program.aleo;
+program_name="test_program.aleo"
+echo "program ${program_name};
 
 function main:
     input r0 as u32.public;
@@ -147,7 +148,7 @@ constructor:
 " > program/main.aleo
 
 echo "{
-  \"program\": \"test_program.aleo\",
+  \"program\": \"${program_name}\",
   \"version\": \"0.1.0\",
   \"description\": \"\",
   \"license\": \"\",
@@ -157,12 +158,48 @@ echo "{
 " > program/program.json
 
 # Deploy the test program and wait for the deployment to be processed.
-_deploy_result=$(cd program && snarkos developer deploy --dev-key 0 --network "$network_id" --endpoint=localhost:3030 --broadcast --wait --timeout 10 test_program.aleo)
+_deploy_result=$(cd program && snarkos developer deploy --dev-key 0 --network "$network_id" --endpoint=localhost:3030 --broadcast --wait --timeout 10 "$program_name")
+
+# Ensure we are able to fetch the program fromn the node.
+status_code=$(curl -s -o /dev/null -w "%{http_code}" "http://localhost:3030/v2/$network_name/program/${program_name}/0")
+if (( status_code == 200 )); then
+  echo "✅ Program exists on the node"
+else
+  echo "❌ Test failed! Failed to get program. Code was ${status_code}"
+  exit 1
+fi
+
+# Ensure the latest edition is indeed 0.
+edition=$(curl -s -o /dev/null "http://localhost:3030/v2/$network_name/program/${program_name}/latest_edition")
+if (( edition == 0 )); then
+  echo "✅ Only program edition 0 exists on the node"
+else
+  echo "❌ Test failed! Invalid latest edition {} for test program returned, not 0."
+  exit 1
+fi
+
+# Also check that the latest edition for the default program (credits.aleo) is 0.
+edition=$(curl -s -o /dev/null "http://localhost:3030/v2/$network_name/program/credits.aleo/latest_edition")
+if (( edition == 0 )); then
+  echo "✅ Only program edition 0 exists on the node"
+else
+  echo "❌ Test failed! Invalid latest edition {} for credits.aleo returned, not 0."
+  exit 1
+fi
+
+# Finally, check that we cannot fetch a non-existing edition of a program
+status_code=$(curl -s -o /dev/null -w "%{http_code}" "http://localhost:3030/v2/$network_name/program/${program_name}/1")
+if (( status_code == 404 )); then
+  echo "✅ Only program edition 0 exists on the node"
+else
+  echo "❌ Test failed! Invalid edition returnd ${status}, not 404."
+  exit 1
+fi
 
 # Execute a function in the deployed program and wait for the execution to be processed.
 # Use the old flags here `--query` and `--broadcast=URL` to test they still work.
 # Also, use the v1 API to test it still works.
-execute_result=$(cd program && snarkos developer execute --dev-key 0 --network "$network_id" --query=localhost:3030 "--broadcast=http://localhost:3030/v1/$network_name/transaction/broadcast" test_program.aleo main 1u32 1u32 --wait --timeout 10)
+execute_result=$(cd program && snarkos developer execute --dev-key 0 --network "$network_id" --query=localhost:3030 "--broadcast=http://localhost:3030/v1/$network_name/transaction/broadcast" "$program_name" main 1u32 1u32 --wait --timeout 10)
 
 # Fail if the execution transaction does not exist.
 tx=$(echo "$execute_result" | tail -n 1)
@@ -190,7 +227,7 @@ echo "ℹ️Testing REST API and REST Error Handling"
 # Test invalid transaction data (JsonDataError) returns 422 Unprocessable Content
 echo "Testing invalid transaction data returns 422 status code..."
 (cd program && snarkos developer execute --dev-key 0 --network "$network_id" --endpoint=localhost:3030 \
-  --store txn_data.json --store-format=string test_program.aleo main 1u32 1u32)
+  --store txn_data.json --store-format=string "$program_name" main 1u32 1u32)
 
 # Modify the proof data
 # This changes the last three characters in the hash but keeps the correct length.

.ci/generate_ledger.sh

@@ -50,7 +50,7 @@ trap 'echo "⛔️ Error in $BASH_SOURCE at line $LINENO: \"$BASH_COMMAND\" fail
 
 # Flags used by all ndoes
 common_flags=(--nodisplay --nobanner --noupdater "--network=$network_id"
-  "--log-filter=$log_filter" --allow-external-peers "--dev-num-validators=$total_validators")
+  "--log-filter=$log_filter" "--dev-num-validators=$total_validators")
 
 # Start all validator nodes in the background
 for ((validator_index = 0; validator_index < total_validators; validator_index++)); do

.circleci/config.yml

@@ -77,26 +77,32 @@ commands:
     parameters:
       cache_key:
         type: string
-        default: v3.3.1-rust-1.88.0-snarkos-stable-cache
+        default: v4.2.0-rust-1.88.0-snarkos-stable-cache
     steps:
       - run: set -e
+      - run:
+          name: Prepare environment variables
+          command: |
+            # Note: sccache cache is disabled for now
+            # it causes longer build times and causes some builds to fail
+    
+            # echo 'export "RUSTC_WRAPPER"="$HOME/.bin/sccache"' >> $BASH_ENV
+            # echo 'export "SCCACHE_CACHE_SIZE"="20000M"' >> $BASH_ENV
+            # Disable incremental builds so that sccache works as expected
+            # echo 'export CARGO_INCREMENTAL=0' >> "$BASH_ENV"
       - run:
           name: Install sccache
           command: |
-            export WORK_DIR="$CIRCLE_WORKING_DIRECTORY/.cache/sccache"
-            export SCCACHE_DIR="$CIRCLE_WORKING_DIRECTORY/.cache/sccache"
+            export SCCACHE_DIR="$HOME/.cache/sccache"
             export SCCACHE_VERSION=v0.10.0
             export SCCACHE_PKG="sccache-$SCCACHE_VERSION-x86_64-unknown-linux-musl"
 
-            mkdir -p "$CIRCLE_WORKING_DIRECTORY/.bin"
+            mkdir -p "$HOME/.bin"
             wget "https://github.com/mozilla/sccache/releases/download/$SCCACHE_VERSION/$SCCACHE_PKG.tar.gz"
-            tar -C "$CIRCLE_WORKING_DIRECTORY/.bin" -xvf "$SCCACHE_PKG.tar.gz"
-            chmod +x "$CIRCLE_WORKING_DIRECTORY/.bin/$SCCACHE_PKG/sccache"
-            mv "$CIRCLE_WORKING_DIRECTORY/.bin/$SCCACHE_PKG/sccache" "$CIRCLE_WORKING_DIRECTORY/.bin/sccache"
-            rm -rf "$CIRCLE_WORKING_DIRECTORY/.cargo/registry"
-
-            export PATH="$PATH:$CIRCLE_WORKING_DIRECTORY/.bin"
-            export RUSTC_WRAPPER="sccache"
+            tar -C "$HOME/.bin" -xvf "$SCCACHE_PKG.tar.gz"
+            chmod +x "$HOME/.bin/$SCCACHE_PKG/sccache"
+            mv "$HOME/.bin/$SCCACHE_PKG/sccache" "$HOME/.bin/sccache"
+            rm -rf "$HOME/.cargo/registry"
       - run:
           name: Install Debian packages
           command: |
@@ -111,15 +117,19 @@ commands:
     parameters:
       cache_key:
         type: string
-        default: v3.3.1-rust-1.88.0-snarkos-stable-cache
+        default: v4.2.0-rust-1.88.0-snarkos-stable-cache
     steps:
-      - run: (sccache -s||true)
       - run: set +e
+      - run:
+          name: "Show sccache statistics"
+          command: $HOME/.bin/sccache -s
       - save_cache:
           key: << parameters.cache_key >>
           paths:
-            - .cache/sccache
-            - .cargo
+            # Store the sccache files
+            - ~/.cache/sccache
+            # Store the cargo registry
+            - ~/.cargo
 
   run_serial:
     description: "Build and run tests"
@@ -134,12 +144,17 @@ commands:
     steps:
       - checkout
       - setup_environment:
-          cache_key:  v3.3.1-rust-1.88.0-<< parameters.cache_key >>-cache
+          cache_key: v4.2.0-rust-1.88.0-<< parameters.cache_key >>-cache
       - run:
+          name: "Build tests"
+          no_output_timeout: 30m
+          command: cd << parameters.workspace_member >> && RUST_MIN_STACK=67108864 cargo test << parameters.flags >> --no-run
+      - run:
+          name: "Run tests"
           no_output_timeout: 30m
           command: cd << parameters.workspace_member >> && RUST_MIN_STACK=67108864 cargo test << parameters.flags >>
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-<< parameters.cache_key >>-cache
+          cache_key: v4.2.0-rust-1.88.0-<< parameters.cache_key >>-cache
 
   run_serial_long:
     description: "Build and run long running tests"
@@ -297,7 +312,7 @@ jobs:
 
   node-router:
     executor: rust-docker
-    resource_class: << pipeline.parameters.large >>
+    resource_class: << pipeline.parameters.xlarge >>
     steps:
       - run_serial:
           workspace_member: node/router
@@ -349,7 +364,7 @@ jobs:
     steps:
       - run_devnet:
           workspace_member: .
-          cache_key: v3.3.1-rust-1.88.0-devnet-test-cache
+          cache_key: v4.2.0-rust-1.88.0-devnet-test-cache
 
   # Check crates that do not have any tests individually
   check-other-crates:
@@ -358,7 +373,7 @@ jobs:
     steps:
       - checkout
       - setup_environment:
-          cache_key: v3.3.1-rust-1.88.0-check-other-crates-cache
+          cache_key: v4.2.0-rust-1.88.0-check-other-crates-cache
       - run:
           name: Check snarkos-node-metrics crate
           no_output_timeout: 10m
@@ -368,7 +383,7 @@ jobs:
           no_output_timeout: 10m
           command: cargo check --package=snarkos-node-metrics --all-features
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-check-other-crates-cache
+          cache_key: v4.2.0-rust-1.88.0-check-other-crates-cache
 
   check-fmt:
     executor: rust-docker
@@ -377,61 +392,61 @@ jobs:
       - checkout
       - install_rust_nightly
       - setup_environment:
-          cache_key: v3.3.1-rust-1.88.0-fmt-cache
+          cache_key: v4.2.0-rust-1.88.0-fmt-cache
       - run:
           name: Check style
           no_output_timeout: 35m
           command: cargo +nightly fmt --all -- --check
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-fmt-cache
+          cache_key: v4.2.0-rust-1.88.0-fmt-cache
 
   check-unused-dependencies:
     executor: rust-docker
     resource_class: << pipeline.parameters.medium >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v3.3.1-rust-1.88.0-machete-cache
+          cache_key: v4.2.0-rust-1.88.0-machete-cache
       - run:
           name: Check for unused dependencies
           no_output_timeout: 10m
           command: |
             cargo install [email protected]
             cargo machete
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-machete-cache
+          cache_key: v4.2.0-rust-1.88.0-machete-cache
 
   check-cargo-audit:
     executor: rust-docker
     resource_class: << pipeline.parameters.medium >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v3.3.1-rust-1.88.0-cargo-audit-cache
+          cache_key: v4.2.0-rust-1.88.0-cargo-audit-cache
       - run:
           name: Check for security vulnerabilities
           no_output_timeout: 10m
           command: |
             cargo install [email protected] --locked
             cargo audit -D warnings
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-cargo-audit-cache
+          cache_key: v4.2.0-rust-1.88.0-cargo-audit-cache
 
   check-clippy:
     executor: rust-docker
     resource_class: << pipeline.parameters.medium >>
     steps:
       - checkout
       - setup_environment:
-          cache_key: v3.3.1-rust-1.88.0-clippy-cache
+          cache_key: v4.2.0-rust-1.88.0-clippy-cache
       - run:
           name: Check lint
           no_output_timeout: 35m
           command: |
             cargo clippy --workspace --all-targets -- -D warnings
             cargo clippy --workspace --all-targets --all-features -- -D warnings
       - clear_environment:
-          cache_key: v3.3.1-rust-1.88.0-clippy-cache
+          cache_key: v4.2.0-rust-1.88.0-clippy-cache
 
   verify-windows:
     executor:

.devnet/start.sh

@@ -43,7 +43,7 @@ start_snarkos_in_tmux() {
     tmux new-session -d -s snarkos-session
 
     # Send the snarkOS start command to the tmux session with the NODE_ID
-    tmux send-keys -t "snarkos-session" "snarkos start --nodisplay --bft 0.0.0.0:5000 --rest 0.0.0.0:3030 --allow-external-peers --peers $NODE_IP:4130 --validators $NODE_IP:5000 --rest-rps 1000 --verbosity $VERBOSITY --network $NETWORK_ID --dev $NODE_ID --dev-num-validators $NUM_INSTANCES --validator --metrics" C-m
+    tmux send-keys -t "snarkos-session" "snarkos start --nodisplay --bft 0.0.0.0:5000 --rest 0.0.0.0:3030 --peers $NODE_IP:4130 --validators $NODE_IP:5000 --rest-rps 1000 --verbosity $VERBOSITY --network $NETWORK_ID --dev $NODE_ID --dev-num-validators $NUM_INSTANCES --validator --metrics" C-m
 
     exit  # Exit root user
 EOF

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,13 +1,17 @@
-<!-- Thank you for filing a PR! Help us understand by explaining your changes. Happy contributing! -->
+Thank you for submitting the PR! We appreciate you spending the time to work on these changes!
 
 ## Motivation
 
-(Write your motivation here)
+Write your motivation here, make sure to link related issues and PRs.
 
 ## Test Plan
 
-(If you changed any code, please provide clear instructions on how you verified your changes work.)
+If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
 
-## Related PRs
+## Documentation
 
-(Link any related PRs here)
+If this PR adds or changes functionality, consider clarifying which docs need to be updated, e.g. on [AleoNet/welcome](https://github.com/AleoNet/welcome).
+
+## Backwards compatibility
+
+Please review backwards compatibility. Does any functionality need to be guarded by an existing or new `ConsensusVersion`?