Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Quantumke/plotly.py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Quantumke/plotly.py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: move-figure-factory
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 2, 2015

  1. Move FigureFactory/etc. into graph_objs package.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    81fd207 View commit details
    Browse the repository at this point in the history

  2. Un-protect the graph_objs imports.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    0c70300 View commit details
    Browse the repository at this point in the history

  3. Add utf-8 encoding for ‘∩’ character in a comment?

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    3bf507a View commit details
    Browse the repository at this point in the history

  4. pep:8ball: extra blank line

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    4c6603f View commit details
    Browse the repository at this point in the history

  5. Change FigureFactory import, auto refact was poor.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    8b95a0b View commit details
    Browse the repository at this point in the history

  6. Maintain backwards compat, but throw a warning.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    76d3ba2 View commit details
    Browse the repository at this point in the history

  7. More pep:8ball: 

    * line too long
* bad line breaking at operators (e.g., `*`)
* continuation line over-intented
    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    647a3d3 View commit details
    Browse the repository at this point in the history

  8. 🎎 fixes.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    b0a02bd View commit details
    Browse the repository at this point in the history

  9. A quick 🐄-tip on unnecessary parentheses.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    4363436 View commit details
    Browse the repository at this point in the history

  10. removing variables that are defined and not used.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    f3b7821 View commit details
    Browse the repository at this point in the history

  11. Fix mutable default args in call signature. 

    Note that default arguments are used in all function calls. This means
that you can get some unexpected storage of previous defaults! It’s best
practice not to do this.
    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    33534cf View commit details
    Browse the repository at this point in the history

  12. Stop using dynamically-defined objects. 

    IDEs hate this… besides, this is internal code. The important part is
that we eventually validate our work by instantiating a `Figure`.

We can use the publicly hidden `GraphObjectFactory` for this purpose.
    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    1192f62 View commit details
    Browse the repository at this point in the history

  13. Return a Figure object from create_dendrogram.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    6428683 View commit details
    Browse the repository at this point in the history

  14. Fix suggested import to please the 🎎

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    e685d70 View commit details
    Browse the repository at this point in the history

  15. Remove commented-out Distplot test.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    6dba45a View commit details
    Browse the repository at this point in the history

  16. Remove duplicate arrow_len declaration.

    @theengineear
    theengineear committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    03216fa View commit details
    Browse the repository at this point in the history
Loading