add AccessSlot records in trace_call

Author: Rollp0x

.gitignore

@@ -29,5 +29,7 @@ Desktop.ini
 .env.local
 TxInspector.md
 
+examples/proxy_attack.rs
+
 # Backup files
 *~

src/evm/processor.rs

@@ -9,7 +9,7 @@ use std::collections::HashMap;
 use crate::{
     evm::TraceEvm,
     traits::{ResetDB, TraceOutput, TransactionTrace, StorageDiff},
-    types::{SimulationBatch, SimulationTx, SlotChange},
+    types::{SimulationBatch, SimulationTx, SlotAccess},
 };
 
 use crate::errors::{EvmError, RuntimeError};
@@ -87,11 +87,12 @@ where
             for (slot, value) in account.storage.iter() {
                 if value.original_value != value.present_value {
                     // Store slot changes for diff output
-                    diffs.entry(*address).or_insert_with(Vec::new).push(SlotChange {
+                    diffs.entry(*address).or_insert_with(Vec::new).push(SlotAccess {
                         address: *address,
                         slot: *slot,
                         old_value: value.original_value,
                         new_value: value.present_value,
+                        is_write: true,
                     });
                 }
             }

src/inspectors/tx_inspector/inspector.rs

@@ -94,7 +94,7 @@ where
             error_origin: false,
             subtraces: Vec::new(),
             trace_address,
-            slot_changes: Vec::new(), // Initialize empty slot changes
+            slot_accesses: Vec::new(), // Initialize empty slot accesses
         };
 
         self.call_traces.push(trace);
@@ -156,7 +156,7 @@ where
             error_origin: false,
             subtraces: Vec::new(),
             trace_address,
-            slot_changes: Vec::new(), // Initialize empty slot changes
+            slot_accesses: Vec::new(), // Initialize empty slot accesses
         };
 
         self.call_traces.push(trace);
@@ -288,17 +288,39 @@ where
                     // Store the slot change in the current call trace
                     let index = self.call_stack.last().unwrap();
                     let call_trace = &mut self.call_traces[*index];
-                    call_trace.slot_changes.push(SlotChange {
+                    call_trace.slot_accesses.push(SlotAccess {
                         address: target,
                         slot,
                         old_value: old,
                         new_value: value,
+                        is_write: true, // This is a write operation
                     });
                     // Update the slot cache
                     self.slot_cache.insert((target, slot), value);
                 }
                 _ => {}
             }
+        } else if opcode == 0x54 && self.call_stack.last().is_some() {
+            let slot = interp.stack.pop();
+            if let Some(slot) = slot {
+                let _ = interp.stack.push(slot);
+                let target = interp.input.target_address();
+                let cached = self.slot_cache.get(&(target, slot));
+                let value = if let Some(old) = cached {
+                    *old
+                } else {
+                    context.db().storage(target, slot).unwrap_or_default()
+                };
+                let index = self.call_stack.last().unwrap();
+                let call_trace = &mut self.call_traces[*index];
+                call_trace.slot_accesses.push(SlotAccess {
+                    address: target,
+                    slot,
+                    old_value: value,
+                    new_value: value,
+                    is_write: false, // This is a read operation
+                });
+            }
         }
     }
 }

src/traits.rs

@@ -1,5 +1,5 @@
 use crate::errors::EvmError;
-use crate::types::{SimulationBatch, SlotChange};
+use crate::types::{SimulationBatch, SlotAccess};
 use revm::context_interface::result::ExecutionResult;
 use revm::inspector::{Inspector, NoOpInspector};
 use std::collections::HashMap;
@@ -220,7 +220,7 @@ impl TraceOutput for () {
         // No output for unit type
     }
 }
-pub type StorageDiff = HashMap<Address, Vec<SlotChange>>;
+pub type StorageDiff = HashMap<Address, Vec<SlotAccess>>;
 pub type TraceResult<T> = Result<(ExecutionResult, StorageDiff, T), EvmError>;
 
 /// Defines standard transaction processing capabilities

src/types.rs

@@ -12,7 +12,7 @@ pub use revm::{
     database::AlloyDB,
     interpreter::{CallScheme, CreateScheme},
 };
-use serde::Serialize;
+use serde::{Serialize, Deserialize};
 
 pub const ERC20_TRANSFER_EVENT_SIGNATURE: FixedBytes<32> =
     fixed_bytes!("0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef");
@@ -187,14 +187,16 @@ impl CallStatus {
 }
 
 /// Storage slot change during a contract call
-#[derive(Debug, Clone, Serialize, Default)]
-pub struct SlotChange {
+#[derive(Debug, Clone, Serialize, Deserialize,Default)]
+pub struct SlotAccess {
     pub address: Address,
     pub slot: U256,
     pub old_value: U256,
     pub new_value: U256,
+    pub is_write: bool, // true=write, false=read
 }
 
+
 /// Detailed trace of a contract call
 #[derive(Debug, Clone, Serialize, Default)]
 pub struct CallTrace {
@@ -222,8 +224,8 @@ pub struct CallTrace {
     pub subtraces: Vec<CallTrace>,
     /// Position in the call tree
     pub trace_address: Vec<usize>,
-    /// Changes to contract storage slots during this call
-    pub slot_changes: Vec<SlotChange>,
+    /// Access to contract storage slots during this call
+    pub slot_accesses: Vec<SlotAccess>,
 }
 
 impl TokenTransfer {