ci.yml: fix ci, fix clippy lint

Author: 71

.github/workflows/ci.yml

@@ -10,26 +10,28 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+
       - uses: actions-rs/toolchain@88dc2356392166efad76775c878094f4e83ff746
         with:
           profile: minimal
           toolchain: "1.60"  # MSRV
           override: true
+          components: rustfmt, clippy
 
       - name: Tests
         uses: actions-rs/cargo@9e120dd99b0fbad1c065f686657e914e76bd7b72
         with:
           command: test  # Test debug assertions; we don't test with `--release` because it enables a lot more CPU-heavy tests.
 
-      - run: rustup component add rustfmt
       - name: Rustfmt
+        if: success() || failure()
         uses: actions-rs/cargo@9e120dd99b0fbad1c065f686657e914e76bd7b72
         with:
           command: fmt
           args: --all -- --check
 
-      - run: rustup component add clippy
       - name: Clippy
+        if: success() || failure()
         uses: actions-rs/cargo@9e120dd99b0fbad1c065f686657e914e76bd7b72
         with:
           command: clippy

src/lib.rs

@@ -195,9 +195,7 @@ pub fn generate_salt(website: &str, username: &str, counter: u32) -> std::vec::V
 
     // SAFETY: `uninit_output` was fully initialized in
     // `generate_salt_to_uninit`.
-    unsafe {
-        std::mem::transmute::<std::vec::Vec<MaybeUninit<u8>>, std::vec::Vec<u8>>(uninit_output)
-    }
+    unsafe { assume_init_vec(uninit_output) }
 }
 
 /// The minimum length of the entropy in bytes, inclusive.
@@ -367,9 +365,7 @@ pub fn render_password(entropy: &[u8], charset: CharacterSet, len: usize) -> std
 
     // SAFETY: `uninit_output` was fully initialized in
     // `render_password_to_uninit`.
-    let output = unsafe {
-        std::mem::transmute::<std::vec::Vec<MaybeUninit<u8>>, std::vec::Vec<u8>>(uninit_output)
-    };
+    let output = unsafe { assume_init_vec(uninit_output) };
 
     // SAFETY: characters are all extracted from `charset`, which only contains
     // a limited set of ASCII characters.
@@ -430,6 +426,15 @@ fn uninit_vec<T>(len: usize) -> std::vec::Vec<MaybeUninit<T>> {
         .collect()
 }
 
+#[cfg(feature = "std")]
+#[inline(always)]
+unsafe fn assume_init_vec(mut vec: std::vec::Vec<MaybeUninit<u8>>) -> std::vec::Vec<u8> {
+    let (ptr, length, capacity) = (vec.as_mut_ptr(), vec.len(), vec.capacity());
+
+    std::mem::forget(vec);
+    std::vec::Vec::from_raw_parts(ptr.cast(), length, capacity)
+}
+
 #[cfg(test)]
 mod fingerprint_tests {
     use super::*;