using secrets

Author: aballaci

springboot-jpa.yaml

@@ -1,3 +1,10 @@
+kind: Secret
+apiVersion: v1
+metadata:
+  name: mysql-connection-secret
+data:
+  password: c2FraWxh
+---
 apiVersion: v1
 kind: Service
 metadata:
@@ -30,7 +37,10 @@ spec:
           image: aballaci/mysql-5.7-sakila:latest
           env:
             - name: MYSQL_ROOT_PASSWORD
-              value: sakila
+              valueFrom:
+                   secretKeyRef:
+                     name: mysql-connection-secret
+                     key: password
           livenessProbe:
             exec:
               command: ["mysqladmin", "ping"]
@@ -40,7 +50,7 @@ spec:
           readinessProbe:
             exec:
               # Check we can execute queries over TCP (skip-networking is off).
-              command: ["mysql", "-h", "127.0.0.1", "-psakila", "-e", "SELECT 1"]
+              command: ["mysql", "-psakila", "-h", "127.0.0.1", "-e", "SELECT 1"]
             initialDelaySeconds: 5
             periodSeconds: 2
             timeoutSeconds: 1
@@ -74,14 +84,19 @@ spec:
     spec:
       containers:
       - name: springboot-jpa
-        image: aballaci/springboot-sakila-jpa:v1
+        image: aballaci/springboot-sakila-jpa:v2
         resources:
           requests:
             cpu: 100m
             memory: 100Mi
         env:
           - name: MYSQL_HOST
             value: mysql
+          - name: MYSQL_ROOT_PASSWORD
+            valueFrom:
+                secretKeyRef:
+                  name: mysql-connection-secret
+                  key: password
         ports:
         - containerPort: 8080
       initContainers:

src/main/resources/application.properties

@@ -1,4 +1,4 @@
 spring.jpa.hibernate.ddl-auto=none
 spring.datasource.url=jdbc:mysql://${MYSQL_HOST:localhost}:3306/sakila
 spring.datasource.username=root
-spring.datasource.password=sakila
+spring.datasource.password=${MYSQL_ROOT_PASSWORD}