fix version comparison (danielpaulus#446)

danielpaulus · web-flow · commit 7cc64c8634b9 · 2024-08-03T21:21:18.000+02:00
Fixes a bug that made iOS18 use the old tunnel and fail.
diff --git a/ios/tunnel/tunnel_api.go b/ios/tunnel/tunnel_api.go
@@ -360,7 +360,8 @@ type manualPairingTunnelStart struct {
 }
 
 func (m manualPairingTunnelStart) StartTunnel(ctx context.Context, device ios.DeviceEntry, p PairRecordManager, version *semver.Version, userspaceTUN bool) (Tunnel, error) {
-	if version.Major() >= 17 && version.Minor() >= 4 {
+
+	if version.GreaterThan(semver.MustParse("17.4.0")) {
 		if userspaceTUN {
 			tun, err := ConnectUserSpaceTunnelLockdown(device, device.UserspaceTUNPort)
 			tun.UserspaceTUN = true

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,8 @@ type manualPairingTunnelStart struct {`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`func (m manualPairingTunnelStart) StartTunnel(ctx context.Context, device ios.DeviceEntry, p PairRecordManager, version *semver.Version, userspaceTUN bool) (Tunnel, error) {`
`363`		`- if version.Major() >= 17 && version.Minor() >= 4 {`
	`363`	`+`
	`364`	`+ if version.GreaterThan(semver.MustParse("17.4.0")) {`
`364`	`365`	`if userspaceTUN {`
`365`	`366`	`tun, err := ConnectUserSpaceTunnelLockdown(device, device.UserspaceTUNPort)`
`366`	`367`	`tun.UserspaceTUN = true`