JS Project Recipe Library - Gabriella #58
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| # js-project-recipe-library | ||
| Link to Netlify: https://js-recipe-library.netlify.app/ |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Recipe Library</title> | ||
| <link rel="stylesheet" href="./style.css"> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.15.4/css/all.min.css"> | ||
| </head> | ||
| <body> | ||
| <div class="top-container"> | ||
| <input | ||
| class="search-button" | ||
| id="search-button" | ||
| type="search" | ||
| placeholder="🔍 Search..."> | ||
| <button | ||
| class="favorite-button btn" | ||
| id="favorite-button"> | ||
| My favorite recipes | ||
| <i | ||
| class="fas fa-heart" | ||
| id="favorite-button-heart"> | ||
| </i> | ||
| </button> | ||
| </div> | ||
| <h1 class="title">Recipe Library</h1> | ||
| <div class="controls-container"> | ||
| <div class="filter-container"> | ||
| <h2>Filter on kitchen</h2> | ||
| <div class="filter-buttons-container"> | ||
| <button | ||
| class="btn active" | ||
| id="filter-all-button"> | ||
| All | ||
| </button> | ||
| <button class="btn">African</button> | ||
| <button class="btn">American</button> | ||
| <button class="btn">Asian</button> | ||
| <button class="btn">Italian</button> | ||
| <button class="btn">Mediterranean</button> | ||
| <button class="btn">Mexican</button> | ||
| <button class="btn">Indian</button> | ||
| </div> | ||
| </div> | ||
| <div class="sort-random-container"> | ||
| <div class="sort-container"> | ||
| <h2>Sort on cooking time</h2> | ||
| <div class="sort-buttons-container"> | ||
| <button class="btn">Descending</button> | ||
| <button class="btn">Ascending</button> | ||
| </div> | ||
| </div> | ||
| <div class="random-container"> | ||
| <h2>Can't decide?</h2> | ||
| <div class="random-button-container"> | ||
| <button | ||
| class="btn" | ||
| id="random-button"> | ||
| Get me a random recipe! | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div | ||
| class="modal-overlay hidden" | ||
| id="modal-overlay"> | ||
| <img | ||
|
Comment on lines
+66
to
+69
There was a problem hiding this comment. Regarding the modal, take a look at the html element |
||
| class="cross-icon" | ||
| id="cross-icon" | ||
| src="./cross-white.svg" | ||
| alt="cross icon"> | ||
| <div | ||
| class="modal" | ||
|
There was a problem hiding this comment. Cool use of "modal", also in js. I have not seen this before:) |
||
| id="modal-popup"> | ||
| <div | ||
| class="modal-content" | ||
| id="modal-content"> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div | ||
| class="card-container" | ||
| id="card-container"> | ||
| </div> | ||
| <script src="./script.js"></script> | ||
| </body> | ||
|
There was a problem hiding this comment. Good and easy-to-understand structure in your HTML, really nice :) Maybe you could use more semantic tags like “main” and “section” to make it even more accessible. |
||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally get the choice of the name but maybe for further clarity "search-input" could be another option for it, since it's "not really" a button:)