🔔🔋 Battery Status & Level Alert Enhancements #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🔋 Added settings for low/high battery notifications (user can choose the % threshold). - 🎵 Introduced the ability to select system sounds for power status, low battery, and high battery notifications. - 🖥️ Updated SettingsView to allow users to pick sounds for each notification type. - 🛠️ Updated SettingsView with new pickers for configuring thresholds. - ⚡ Improved BatteryStatusViewModel to handle customizable battery level thresholds. - ⚡ Extended BatteryStatusViewModel and Constants to support and trigger these sound alerts.
Member
|
Sorry about the delay in getting to this. It looks great! Can you fix the conflicts? |
Contributor
Author
I’ve resolved the merge conflicts 🔧✨ |
Alexander5015
requested changes
Nov 17, 2025
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Co-authored-by: Alexander <[email protected]>
Member
Alexander5015
left a comment
Alexander5015
left a comment
There was a problem hiding this comment.
Thanks for the update! It looks like the build is currently failing. Could you review the CI logs and address the errors?
Moved the closing brace for the header section in the Charge view to ensure proper SwiftUI section structure.
Contributor
Author
Fixed! Just a missing ‘)’. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔋🎵 Brief summary:
The battery notification system was enhanced, allowing users to configure both the battery thresholds for alerts and the custom sounds for each notification type.
📝 Actions performed: