- Fixed an issue that caused the Obsidian CodeEditor to default to an invalid theme name.

cabal95 · cabal95 · commit ca993c469f3f · 2025-05-13T09:16:53.000-07:00
diff --git a/Rock.JavaScript.Obsidian/Framework/Controls/codeEditor.obs b/Rock.JavaScript.Obsidian/Framework/Controls/codeEditor.obs
@@ -194,7 +194,7 @@
 
     // Since themes can be passed in as the number or string, we need to convert it to the string version
     const themeName = computed<string>(() => {
-        if (props.theme === 0 && props.editor === "ace") {
+        if ((props.theme === 0 || props.theme === "rock") && props.editor === "ace") {
             return "github";
         }
 

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@`
`194`	`194`
`195`	`195`	`// Since themes can be passed in as the number or string, we need to convert it to the string version`
`196`	`196`	`const themeName = computed<string>(() => {`
`197`		`- if (props.theme === 0 && props.editor === "ace") {`
	`197`	`+ if ((props.theme === 0 \|\| props.theme === "rock") && props.editor === "ace") {`
`198`	`198`	`return "github";`
`199`	`199`	`}`
`200`	`200`