Skip to content

Conversation

@LEO33SoFo
Copy link

@LEO33SoFo LEO33SoFo commented Aug 18, 2020

Changes proposed:

  • Adding Solo_LFG to the latest current TrinityCore version.

Target branch(es): 3.3.5-lfgsolo

Tests performed: It builds successfully, basic in-game tested.

@Aokromes
Copy link
Member

server/scripts/Custom/Lfg_Solo.cpp:36:25: fatal error: unused parameter 'player' [-Wunused-parameter]
void OnLogin(Player* player, bool /loginFirst/)
^
1 error generated.

@LEO33SoFo LEO33SoFo closed this Aug 18, 2020
@LEO33SoFo LEO33SoFo deleted the 3.3.5-lfgsolo branch August 18, 2020 09:48
@LEO33SoFo
Copy link
Author

I tested the wrong version. It builds successfully with this one: TrinityCore/TrinityCore@4398695.

@Aokromes
Copy link
Member

na, that error is strict compile settings on our build bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants