3.3.5 lfgsolo #25
Closed
3.3.5 lfgsolo #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d units (#25229) * Core/AI: Remove code that removed UNIT_DYNFLAG_LOOTABLE from possessed units * Update PassiveAI.cpp Restored logic that removes loot flag while being possessed * Restored logic that removes loot flag while being possessed
Closes #25241
Closes #25245
…e correctly and fix script stuck Closes #25244
…amas) Closes #16490
Closes #13055
…pells from sniffs
remove incorrect check, source: https://www.wowhead.com/spell=53606/the-light-of-dawn Flags Can be used while dead https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830 https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
* Core/PacketIO: Update SMSG_QUESTGIVER_QUEST_DETAILS * Core/PacketIO: Name RewardFactionFlags field of QuestInfo struct
…it (#25248) Mostly to make clang-tidy happier
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter * Scripts/HoR: Fix wrong emote during escape event * Core/Unit: Make improve type safety of HandleEmoteCommand Change argument type to the expected enum type Emote * Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE UNIT_NPC_EMOTESTATE is no flag field
The check above is what I use to actually get a real result for LUA_STR_CHECK, which when I used variables that would have a string to them it actually fails the check. When checking for items like a function if it exists of course it won't work... In addition, fixing the Unk2 to Unk3 causes people to be able to adjust the address of the check to the address 0x00419210 to make warden perform the FrameScript__Execute to run lua on the client. This seems to be the big request like in TrinityCore/TrinityCore#23035
…nto the legacy spawn group
…5256) * Core/Shared: Make Emote enum smart * Scripts/Commands: Use enum type arg for HandleDebugAnimCommand
…rently casting another spell will be retried asap with priority over other events (#25238) * Core/SAI: Spell casts that cannot be executed because the unit is currently casting another spell will be retried asap with priority over other events * Core/SAI: Re-sort the events only when needed * Fix some priority reset and wrong mEventSortingRequired handling * Code cleanup. Sort only events loaded from db (not stored events, not timed action list). * Code cleanup. Raise priority of failed casts so they are retried before other spells * Keep priority of the action fails and is rescheduled on next update * Don't try recasting a spell in SMART_ACTION_CAST if there are multiple targets and at least 1 was successful
… (PR #25259) Check if integral/floating point type arguments were parsed successfully. std::stoull will happily parse floating point strings until the decimal separator and return the value. Make sure for all parsing methods that we actually parsed the whole token. This allows to use handler arguments like Variant<uint32, float> which will be populated with the right type depending on the token value (e.g "10" vs "10.0").
* Core/Pets: Pet management refactoring * Preload basic pet data on character login with async query * Load additional pet data (declined names/auras/spells/cooldowns) using async query after we are sure pet loading will succeed * Remove all select queries related to pet stable/unstable * Remove all silent pet deletions except explicit UI-triggered abandons * Fixed displaying stable master content when current pet is not summoned * Allow to stable/swap unsummoned current pet Closes #3610 Closes #21266
Closes #25250
No longer needed after TrinityCore/TrinityCore@ca25e8d Explained in TrinityCore/TrinityCore#24914 Some event types not affected because requires tests, events with No Repeat event flag skipped
…o some areatriggers
…amic scaling spawn group
…riant to std::variant, which means we no longer need visitors
…riant to std::variant (for real this time)
Co-authored-by: Warpten <[email protected]> Co-authored-by: Ovahlord <[email protected]> Co-authored-by: Carbenium <[email protected]>
…mation() -> GetAnimationTier(), dad1876 follow-up
Updates #25193 Co-authored-by: Keader Co-authored-by: Ovahlord (sucker)
Co-authored-by: Houston <[email protected]> Co-authored-by: offl <[email protected]>
Handled in SpellDifficulty.dbc Ref ca9c746
Closes #25420 Before 3.0.2 his quests were available after 'Omarion's Handbook' (cannot be obtained currently)
Closes #25411
…date VerifiedBuild
…ad of .exe Closes #24664
… return nullptr (PR #25431)
…32767]. 08064f0 follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
23 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Target branch(es): 3.3.5-lfgssolo
Issues addressed: Fixes #20
Tests performed: build and test in game.
Known issues and TODO list:
n/a