Skip to content

Commit 2042d23

Browse files
killerwifekillerwife
committed
Fix CreateObject2 and CreateObject1 parsing
Values is not parsing yet
1 parent 4b8eb82 commit 2042d23

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+5382
-6
lines changed

‎WowPacketParser/Enums/ClientType.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ public enum ClientType
1414
Classic = 7,
1515
Shadowlands = 8,
1616
ClassicSoM = 8,
17+
ClassicHardcore = 8,
1718
BurningCrusadeClassic = 8,
1819
WotLKClassic = 8,
1920
Dragonflight = 9,

‎WowPacketParser/Enums/Version/Opcodes.cs‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@
7373
using WowPacketParser.Enums.Version.V10_1_7_51187;
7474
using WowPacketParser.Enums.Version.V10_2_0_52038;
7575
using WowPacketParser.Misc;
76+
using WowPacketParser.Enums.Version.V1_14_4_51146;
7677

7778
namespace WowPacketParser.Enums.Version
7879
{
@@ -840,9 +841,10 @@ public static ClientVersionBuild GetOpcodeDefiningBuild(ClientVersionBuild build
840841
case ClientVersionBuild.V3_4_2_50250:
841842
case ClientVersionBuild.V3_4_2_50375:
842843
case ClientVersionBuild.V3_4_2_50664:
843-
case ClientVersionBuild.V1_14_4_51146:
844-
case ClientVersionBuild.V1_14_4_51535:
845844
return ClientVersionBuild.V3_4_2_50129;
845+
case ClientVersionBuild.V1_14_4_51146: // inherits from above
846+
case ClientVersionBuild.V1_14_4_51535:
847+
return ClientVersionBuild.V1_14_4_51146;
846848
case ClientVersionBuild.V3_4_3_51505:
847849
case ClientVersionBuild.V3_4_3_51572:
848850
case ClientVersionBuild.V3_4_3_51666:
@@ -999,6 +1001,8 @@ public static BiDictionary<Opcode, int> GetOpcodeDictionary(ClientVersionBuild b
9991001
return Opcodes_1_13_6.Opcodes(direction);
10001002
case ClientVersionBuild.V1_14_1_40688:
10011003
return Opcodes_1_14_1.Opcodes(direction);
1004+
case ClientVersionBuild.V1_14_4_51146:
1005+
return Opcodes_1_14_4.Opcodes(direction);
10021006
case ClientVersionBuild.V2_5_1_38835:
10031007
return Opcodes_2_5_1.Opcodes(direction);
10041008
case ClientVersionBuild.V2_5_2_39570:

‎WowPacketParser/Enums/Version/UpdateFields.cs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -937,10 +937,13 @@ private static string GetUpdateFieldDictionaryBuildName(ClientVersionBuild build
937937
case ClientVersionBuild.V1_14_3_48611:
938938
case ClientVersionBuild.V1_14_3_49229:
939939
case ClientVersionBuild.V1_14_3_49821:
940+
{
941+
return "V1_14_3_42770";
942+
}
940943
case ClientVersionBuild.V1_14_4_51146:
941944
case ClientVersionBuild.V1_14_4_51535:
942945
{
943-
return "V1_14_3_42770";
946+
return "V1_14_4_51146";
944947
}
945948
case ClientVersionBuild.V2_5_1_38598:
946949
case ClientVersionBuild.V2_5_1_38644:

‎WowPacketParser/Enums/Version/V1_14_4_51146/Opcodes.cs‎

Lines changed: 715 additions & 0 deletions
Large diffs are not rendered by default.

‎WowPacketParser/Misc/ClientVersion.cs‎

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1105,8 +1105,6 @@ public static ClientVersionBuild GetVersionDefiningBuild(ClientVersionBuild buil
11051105
case ClientVersionBuild.V1_14_3_48611:
11061106
case ClientVersionBuild.V1_14_3_49229:
11071107
case ClientVersionBuild.V1_14_3_49821:
1108-
case ClientVersionBuild.V1_14_4_51146:
1109-
case ClientVersionBuild.V1_14_4_51535:
11101108
case ClientVersionBuild.V2_5_1_38598:
11111109
case ClientVersionBuild.V2_5_1_38644:
11121110
case ClientVersionBuild.V2_5_1_38707:
@@ -1192,6 +1190,8 @@ public static ClientVersionBuild GetVersionDefiningBuild(ClientVersionBuild buil
11921190
case ClientVersionBuild.V3_4_2_50250:
11931191
case ClientVersionBuild.V3_4_2_50375:
11941192
case ClientVersionBuild.V3_4_2_50664:
1193+
case ClientVersionBuild.V1_14_4_51146:
1194+
case ClientVersionBuild.V1_14_4_51535:
11951195
case ClientVersionBuild.V3_4_3_51505:
11961196
case ClientVersionBuild.V3_4_3_51572:
11971197
case ClientVersionBuild.V3_4_3_51666:
@@ -1259,6 +1259,8 @@ private static ClientType GetExpansion(ClientVersionBuild build)
12591259
return ClientType.BurningCrusadeClassic;
12601260
if (IsWotLKClientVersionBuild(build))
12611261
return ClientType.WotLKClassic;
1262+
if (IsClassicHardcoreClientVersionBuild(build))
1263+
return ClientType.ClassicHardcore;
12621264

12631265
if (build >= ClientVersionBuild.V10_0_0_46181)
12641266
return ClientType.Dragonflight;
@@ -1286,7 +1288,7 @@ private static ClientType GetExpansion(ClientVersionBuild build)
12861288

12871289
private static ClientBranch GetBranch(ClientVersionBuild build)
12881290
{
1289-
if (IsClassicVanillaClientVersionBuild(build) || IsClassicSeasonOfMasteryClientVersionBuild(build))
1291+
if (IsClassicVanillaClientVersionBuild(build) || IsClassicSeasonOfMasteryClientVersionBuild(build) || IsClassicHardcoreClientVersionBuild(build))
12901292
return ClientBranch.Classic;
12911293
if (IsBurningCrusadeClassicClientVersionBuild(build))
12921294
return ClientBranch.TBC;
@@ -1525,6 +1527,17 @@ public static bool IsClassicSeasonOfMasteryClientVersionBuild(ClientVersionBuild
15251527
case ClientVersionBuild.V1_14_3_48611:
15261528
case ClientVersionBuild.V1_14_3_49229:
15271529
case ClientVersionBuild.V1_14_3_49821:
1530+
1531+
return true;
1532+
default:
1533+
return false;
1534+
}
1535+
}
1536+
1537+
public static bool IsClassicHardcoreClientVersionBuild(ClientVersionBuild build)
1538+
{
1539+
switch (build)
1540+
{
15281541
case ClientVersionBuild.V1_14_4_51146:
15291542
case ClientVersionBuild.V1_14_4_51535:
15301543
return true;

0 commit comments

Comments
 (0)